Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#11700 #11699 Remove pyupgrade from our pre-commit tools #11701

Merged
merged 4 commits into from Oct 5, 2022
Merged

#11700 #11699 Remove pyupgrade from our pre-commit tools #11701

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
380696e
Remove pyupgrade from precommit.
adiroiban Oct 5, 2022
eb872a2
Try 11699 enable parallel local tests by default.
adiroiban Oct 5, 2022
7d4be3b
please re-run CI
glyph Oct 5, 2022
37bbdab
pretty please
glyph Oct 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 0 additions & 5 deletions .pre-commit-config.yaml
View file
Open in desktop
@@ -1,9 +1,4 @@
repos:
- repo: https://github.com/asottile/pyupgrade
rev: v2.23.1
hooks:
- id: pyupgrade
args: ["--py36-plus"]

- repo: https://github.com/pycqa/isort
rev: 5.9.3
Expand Down
Empty file added src/twisted/newsfragments/11700.misc
View file
Open in desktop
Empty file.
4 changes: 2 additions & 2 deletions tox.ini
View file
Open in desktop
Expand Up @@ -93,12 +93,12 @@ commands =
posix: python -c "print('Running on POSIX (no special dependencies)')"

; Run tests without wrapping them using coverage.
nocov: python -m twisted.trial --temp-directory={envtmpdir}/_trial_temp --reporter={env:TRIAL_REPORTER:verbose} {env:TRIAL_ARGS:} {posargs:twisted}
nocov: python -m twisted.trial --temp-directory={envtmpdir}/_trial_temp --reporter={env:TRIAL_REPORTER:verbose} {env:TRIAL_ARGS:-j8} {posargs:twisted}

; Run the tests wrapped using coverage.
withcov: python {toxinidir}/admin/_copy.py {toxinidir}/admin/zz_coverage.pth {envsitepackagesdir}/zz_coverage.pth
withcov: coverage erase
withcov: coverage run -p --rcfile={toxinidir}/.coveragerc -m twisted.trial --temp-directory={envtmpdir}/_trial_temp --reporter={env:TRIAL_REPORTER:verbose} {env:TRIAL_ARGS:} {posargs:twisted}
withcov: coverage run -p --rcfile={toxinidir}/.coveragerc -m twisted.trial --temp-directory={envtmpdir}/_trial_temp --reporter={env:TRIAL_REPORTER:verbose} {env:TRIAL_ARGS:-j8} {posargs:twisted}

lint: pre-commit {posargs:run --all-files --show-diff-on-failure}

Expand Down