#11700 #11699 Remove pyupgrade from our pre-commit tools #11701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adiroiban
changed the title
glyph
approved these changes
Oct 5, 2022
There was a problem hiding this comment.
It looks like the attempt to address #11699 at the same time is hitting coverage, probably because of some obscure problem with coverage.process_startup() not propagating everywhere it needs to. If the codecov status resolves feel free to land as-is, otherwise, drop that patch, land the pyupgrade change, and make a new PR so we can investigate separately
Looks like consistency eventually'd while I was writing that so SHIP IT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope and purpose
Fixes #11700
Fixes #11699
See more info in the ticket.
It looks like pyupgrade has good intentions...but it is broken.
As a drive-by it also enabled the parallel test runs for trial by default.
This should result in much faster tests.
It should also (forcefully :) expose more people to this wonderful feature of
trial.