Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#11664 Initial run on macOS on GHA. #11665

Merged
merged 4 commits into from Sep 14, 2022
Merged

#11664 Initial run on macOS on GHA. #11665

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
06b0093
Initial run on macOS on GHA.
adiroiban Sep 14, 2022
6091eac
Run tests on older macos and python.
adiroiban Sep 14, 2022
67355c8
Add macos version to job name.
adiroiban Sep 14, 2022
45989d3
Try to see 3.7.12 works on macos.
adiroiban Sep 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 6 additions & 1 deletion .github/workflows/test.yaml
View file
Open in desktop
Expand Up @@ -122,6 +122,11 @@ jobs:
# Just Python 3.9 with default settings.
- python-version: '3.9'

# newest macOS and newest Python supported version.
- python-version: '3.10'
runs-on: 'macos-12'
job-name: 'macos-default-tests'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be good to keep testing an older version of Python on macOS. On Azure it looks like we tested 3.7 - 3.10. Perhaps we can at least test 3.7 and 3.10 (skipping the intermediates) on GA.


# Windows, minimum Python version with select reactor.
- python-version: '3.7'
runs-on: 'windows-2022'
Expand Down Expand Up @@ -225,7 +230,7 @@ jobs:
# If one of the above steps fails, fire up tmate for remote debugging.
# This is fired for manual trigger or via the environment variable.
- name: Tmate debug session
if: ${{ !cancelled() && (env.TMATE_DEBUG == 'yes' || github.event_name == 'workflow_dispatch' && inputs.debug_enabled ) }}
if: ${{ failure() && (env.TMATE_DEBUG == 'yes' || github.event_name == 'workflow_dispatch' && inputs.debug_enabled ) }}
uses: mxschmitt/action-tmate@v3
with:
limit-access-to-actor: true
Expand Down
23 changes: 0 additions & 23 deletions azure-pipelines/macos_test_jobs.yml
View file
Open in desktop

This file was deleted.

86 changes: 0 additions & 86 deletions azure-pipelines/run_test_steps.yml
View file
Open in desktop

This file was deleted.

33 changes: 0 additions & 33 deletions azure-pipelines/tests_pipeline.yml
View file
Open in desktop

This file was deleted.

Empty file added src/twisted/newsfragments/11664.misc
View file
Open in desktop
Empty file.