#11664 Initial run on macOS on GHA. #11665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adiroiban
force-pushed
the
11664-macos-ci
branch
from
2550f80
to
2f266cb
Compare
adiroiban
force-pushed
the
11664-macos-ci
branch
from
2f266cb
to
06b0093
Compare
exarkun
approved these changes
Sep 14, 2022
.github/workflows/test.yaml
Outdated
| # newest macOS and newest Python supported version. | ||
| - python-version: '3.10' | ||
| runs-on: 'macos-12' | ||
| job-name: 'macos-default-tests' |
There was a problem hiding this comment.
I think it would be good to keep testing an older version of Python on macOS. On Azure it looks like we tested 3.7 - 3.10. Perhaps we can at least test 3.7 and 3.10 (skipping the intermediates) on GA.
|
Thanks for the review. I will enable auto-merge for this. And with this landed, we should be able to generate our independent coverage report.... I will test with towncrier first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope and purpose
Fixes #11664
Run macOS tests on GHA.
Remove Azure pipelines.
Azure pipelines works, but is kind of stucked. The admin account is owned by Amber and no other dev has access to the Azure Devops account.
With GitHub actions, the whole dev team has access to the CI.
What to check