New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix text-break in IE and Edge Legacy #31727
Conversation
Thanks for the PR, but please always make sure CI passes. |
@XhmikosR thanks, could you please clarify how should I proceed with Lint errors in files below?
I didn't touch them, they're the same as current upstream v4-dev branch. |
Those are not errors, they are warnings and unrelated. https://github.com/twbs/bootstrap/pull/31727/checks?check_run_id=1152664809#step:6:53 |
BTW I see why you got confused; GitHub changed something in regard to Actions and the Stylelint errors are not highlighted like the warnings or the parent failed commit. Either way it should be pretty trivial to fix, but for future reference better clone the repo locally so that you run the tests. |
@XhmikosR thanks, I've fixed lint error and updated PR, please review. |
@twbs/css-review can I have a review just so that we are safe please? |
@XhmikosR I've added more detailed comments how |
@@ -63,8 +63,19 @@ | |||
.text-decoration-none { text-decoration: none !important; } | |||
|
|||
.text-break { | |||
word-break: break-word !important; // IE & < Edge 18 | |||
overflow-wrap: break-word !important; | |||
// We wan't to use `overflow-wrap: anywhere` to avoid issues with flex containers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mdo this whole section needs grammar fixes and personally I find it too verbose
See #31793. |
Fix #29319 again.
Correcting Backport #30932 to v4
word-break
didn't supportbreak-word
value in IE and Edge Legacyoverflow-wrap
is absent in IE/Edge Legacy (it's modern replace forword-wrap
)So we need to add back
word-wrap: break-word
for IE and Edge Legacy.