Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc v4 backports #31793

Merged
merged 4 commits into from Oct 5, 2020
Merged

Misc v4 backports #31793

merged 4 commits into from Oct 5, 2020

Conversation

mdo
Copy link
Member

@mdo mdo commented Sep 29, 2020

@mdo mdo requested review from a team as code owners September 29, 2020 20:35
@mdo mdo added this to Inbox in v4.5.3 via automation Sep 29, 2020
@mdo mdo changed the base branch from main to v4-dev September 29, 2020 20:35
@mdo
Copy link
Member Author

mdo commented Sep 30, 2020

Updated @XhmikosR, should be good to go now!

Copy link
Member

@XhmikosR XhmikosR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I'd like another approval from @twbs/css-review for the Sass changes :)

@ihorzenich
Copy link

Please use comments for .text-break from this commit: e501897 for right correct explanation what are they doing.

@XhmikosR
Copy link
Member

XhmikosR commented Oct 3, 2020 via email

@ihorzenich
Copy link

ihorzenich commented Oct 3, 2020

They are too verbose and not really needed.

Ok, but please then at least remove current // IE & < Edge 18 comment because it confuse (see: 0783f63#r42942080)

Manually backports #30781 to v4.
Keeps checkboxes, radios, and switches with their intended design when printing.

Backports #29714
@XhmikosR
Copy link
Member

XhmikosR commented Oct 5, 2020

Friendly ping @twbs/css-review

Copy link
Member

@ffoodd ffoodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XhmikosR XhmikosR merged commit 91d0a65 into v4-dev Oct 5, 2020
@XhmikosR XhmikosR deleted the v4-backports-mdo branch October 5, 2020 13:12
@XhmikosR XhmikosR moved this from Inbox to Shipped in v4.5.3 Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v4.5.3
Shipped
Development

Successfully merging this pull request may close these issues.

None yet

4 participants