Fix sourcemaps #23255
Merged
Fix sourcemaps #23255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually, can someone try this locally who is not on Windows and see if it fixes the issue? I have opened an issue with clean-css because I see the paths using the Windows separator on Windows. |
XhmikosR
changed the title
source-map-inline-sources for clean-css.source-map-inline-sources for clean-css and node-sass.
Specify `--source-map-contents true` for node-sass and `source-map-inline-sources` for clean-css. Without this, the sourcemaps weren't found.
|
OK, I confirmed it fixes the issue for me. |
XhmikosR
force-pushed
the
v4-dev-xmr-sourcemaps
branch
from
e91758a
to
5b01183
Compare
XhmikosR
changed the title
source-map-inline-sources for clean-css and node-sass.
|
I've no idea why this fails elsewhere, but it doesn't break source maps for me, so |
!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, the sourcemaps aren't found for me.
Fixes #23254