Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sourcemap references and CDNs result in 403 responses #19063

Closed
patrickhlauke opened this issue Feb 2, 2016 · 11 comments
Closed

sourcemap references and CDNs result in 403 responses #19063

patrickhlauke opened this issue Feb 2, 2016 · 11 comments

Comments

@patrickhlauke
Copy link
Member

wondering if - at least for CDN versions - there's a way of suppressing sourcemap references to files which aren't available (and result in 403 responses, which get silently absorbed by Chrome/Firefox/Safari dev tools but are - correctly? - exposed by Edge's dev tools) - see http://stackoverflow.com/questions/35142485/why-is-bootstrap-trying-to-load-less-files-in-edge/35151109

/cc @mdo @cvrebert

@patrickhlauke
Copy link
Member Author

xref jsdelivr/bootstrapcdn#629

@cvrebert
Copy link
Collaborator

cvrebert commented Feb 2, 2016

I think there's a config option somewhere to stuff copies of the source files into the sourcemap itself so it doesn't reference any external files. We could try that.

@jdorfman
Copy link
Contributor

jdorfman commented Jul 5, 2016

@patrickhlauke @cvrebert any updates?

@patrickhlauke
Copy link
Member Author

@jdorfman, i think @cvrebert is your man on this one, as I have zero clue about grunt, sourcemaps, etc

@cvrebert
Copy link
Collaborator

cvrebert commented Jul 5, 2016

I'm currently in transit. Will have a go at this in a couple hours when I reach my destination though.

@jdorfman
Copy link
Contributor

jdorfman commented Jul 5, 2016

@cvrebert let me know if @jmervine can be of any assistance. Thanks

@cvrebert
Copy link
Collaborator

Fixed in v3 via #20258.
A v4 fix is still on our TODO.

@mdo mdo modified the milestones: v4.0.0-alpha.3, v4.0.0-alpha.4 Jul 23, 2016
@mdo
Copy link
Member

mdo commented Sep 12, 2016

Was this ever addressed for v4?

@mdo
Copy link
Member

mdo commented Oct 3, 2016

Gah, tried to straight move it over and in my rush missed all the Grunt errors 😁. Will revisit for v4.

@mdo mdo reopened this Oct 3, 2016
@mdo mdo modified the milestones: v4.0.0-alpha.6, v4.0.0-alpha.5 Oct 19, 2016
@mdo mdo modified the milestones: v4.0.0-beta, v4.0.0-alpha.6 Dec 31, 2016
@mdo mdo removed this from the v4.0.0-beta milestone Apr 8, 2017
@Delagen
Copy link
Contributor

Delagen commented May 11, 2017

I think package.json section should include js.map files

 "files": [
    ".babelrc",
    ".eslintignore",
    "Gruntfile.js",
    "dist",
    "build",
    "js/.eslintrc.json",
    "js/**/*.js",
    "js/**/*.js.map", //source-map
    "scss/.scss-lint.yml",
    "scss/**/*.scss",
    "LICENSE"
  ],

@mdo mdo added this to Build system in Feature ideas Aug 4, 2017
@XhmikosR
Copy link
Member

XhmikosR commented Oct 7, 2017

I believe I have enabled all the related switches without knowing about this issue some time ago (see #23255), and source files are embedded in map files.

@Delagen: you are welcome to make a new issue or a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants