Tell clean-css to inline source files into sourcemap #20258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cvrebert ran I am going to post it to bootstrapcdn#629 and see what they say since I don't have Windows 10. |
|
@jmervine cool. I am downloading/installing Windows 10 from https://developer.microsoft.com/en-us/microsoft-edge/tools/vms/ |
|
@cvrebert: while at it how about we take care of that comment too? // TODO: disable `zeroUnits` optimization once clean-css 3.2 is released
// and then simplify the fix for https://github.com/twbs/bootstrap/issues/14837 accordingly |
|
@XhmikosR are you able to test this: https://maxcdn.bootstrapcdn.com/debug/fix-19063-v3/css/bootstrap.min.css I think it fixes the issue people are reporting but I want to make sure. |
|
Yeah, confirmed it works for me on Windows 10 64-bit with Firefox 48.0b6 64-bit.
|
|
I'm gonna rebase and merge this when I'm back at home later if no one beats me to it. |
mdo
added a commit
that referenced
this pull request
Oct 3, 2016
twbs-savage
pushed a commit
to twbs-savage/bootstrap
that referenced
this pull request
Oct 3, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bootstrap v3 fix for #19063.
@jmervine @jdorfman Please test this. If you can confirm the fix, then I'll try to get 3.3.7 shipped ASAP.