New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
carousel: add missing to
description and fix nextwhenvisible
description
#31809
Conversation
to
description and fix nextwhenvisible
description
BTW this is duplicate of #31800 |
@@ -364,6 +364,10 @@ var carousel = new bootstrap.Carousel(myCarousel, { | |||
</tr> | |||
<tr> | |||
<td><code>nextWhenVisible</code></td> | |||
<td>Don't cycle carousel to next when the page isn't visible or the carousel or its parent isn't visible. <strong>Returns to the caller before the target item has been shown</strong> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mdo or @patrickhlauke for word proofing. I feel like a "the" is missing?
@Johann-S does this need a backport or is the option present only in v5? |
yep we should backport this in v4 too 👍 |
I don't see the option at all in v4-dev docs, so I guess we'll need to manually backport it. I'll add it to the 4.5.3 project but any patch to backport it is welcome. |
Manual Backport : #31851 |
Added the to method and corrected nextWhenVisible description in Corousel Component documentation.
Fixes #31788