Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusion on the "nextWhenVisible()" method on Carousel Component #31788

Closed
JudgedPluto opened this issue Sep 29, 2020 · 5 comments · Fixed by #31809
Closed

Confusion on the "nextWhenVisible()" method on Carousel Component #31788

JudgedPluto opened this issue Sep 29, 2020 · 5 comments · Fixed by #31809

Comments

@JudgedPluto
Copy link

Hi everyone, I am currently using bootstrap 5 and while browsing through documentation, I have found that in the carousel component documentation, carousel.prototype.nextWhenVisible() function is not accurate with its description. Although carousel.prototype.to() function seems to be matched with the description (which is not found in the carousel component documentation, but can be found in the code).

I think that the function has been mismatched with the description, that have led me to a confusion.

The section that I am referring to:
https://v5.getbootstrap.com/docs/5.0/components/carousel/#methods

@Johann-S
Copy link
Member

Nice catch @JudgedPluto 👍

You're right, the to method is missing and nextWhenVisible description is wrong

@JudgedPluto
Copy link
Author

Cool, Thank you for the clarification :)

@XhmikosR XhmikosR added this to Inbox in v5.0.0-alpha3 via automation Sep 29, 2020
@suliskh
Copy link

suliskh commented Sep 30, 2020

@JudgedPluto @XhmikosR @Johann-S Is it okay for me to work on this?

@XhmikosR
Copy link
Member

There's no need to ask for such things. Just grab an issue and submit a PR when ready.

I'm thinking we should add this statement somewhere...

@cankitm
Copy link
Contributor

cankitm commented Oct 1, 2020

Made required changes.
#31809

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants