Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

carousel: add missing to description and fix nextwhenvisible description #31809

Merged
merged 3 commits into from Oct 5, 2020
Merged

carousel: add missing to description and fix nextwhenvisible description #31809

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
efb75c5
docs-Update corousel doc : nextwhenvisible and to
Oct 1, 2020
7c40791
Resolved Review Comments
Oct 2, 2020
87db5aa
Merge branch 'main' into corousel-doc-fix
cankitm Oct 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions site/content/docs/5.0/components/carousel.md
View file
Open in desktop
Expand Up @@ -364,6 +364,10 @@ var carousel = new bootstrap.Carousel(myCarousel, {
</tr>
<tr>
<td><code>nextWhenVisible</code></td>
<td>Don't cycle carousel to next when the page isn't visible or the carousel or its parent isn't visible. <strong>Returns to the caller before the target item has been shown</strong>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mdo or @patrickhlauke for word proofing. I feel like a "the" is missing?

</tr>
<tr>
<td><code>to</code></td>
<td>Cycles the carousel to a particular frame (0 based, similar to an array). <strong>Returns to the caller before the target item has been shown</strong> (e.g., before the <code>slid.bs.carousel</code> event occurs).</td>
</tr>
<tr>
Expand Down