Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Sass and migrate / to math.div() #1218

Closed
wants to merge 1 commit into from

Conversation

TylerVigario
Copy link

@TylerVigario TylerVigario commented Jun 3, 2021

Fix for #1217: Using / for division was recently deprecated in Sass.

I've updated the source to use math.div() and moved to Dart Sass (version 1.33).

@kikyous
Copy link

kikyous commented Jul 2, 2021

since this repo is no loger active maintains, i made a npm package use your pr, hope it is usefull
https://www.npmjs.com/package/bootstrap3-sass
https://github.com/kikyous/bootstrap3-sass

install:
npm install bootstrap3-sass

@JeremyCarlsten
Copy link

@TylerVigario Is there a plan to merge this? Seeing it all over our projects aswell.

@TylerVigario
Copy link
Author

@TylerVigario Is there a plan to merge this? Seeing it all over our projects aswell.

Use fork from @kikyous above.

@szysza
Copy link

szysza commented Oct 21, 2021

@kikyous, @TylerVigario after installing the fork with the fix I'm getting the following error:

Error: Invalid CSS after "...     floor(math": expected expression (e.g. 1px, bold), was ".div($grid-gutter-w"
        on line 370 of ../../../../../../.rbenv/versions/2.7.4/lib/ruby/gems/2.7.0/bundler/gems/bootstrap3-sass-bbd592141451/assets/stylesheets/bootstrap/_variables.scss
        from line 8 of ../../../../../../.rbenv/versions/2.7.4/lib/ruby/gems/2.7.0/bundler/gems/bootstrap3-sass-bbd592141451/assets/stylesheets/_bootstrap.scss

which seems to be coming from this line. Any ideas on how to fix the issue? I'm using ruby 2.7.4 and rails in version 6.1.4.1.

@kikyous
Copy link

kikyous commented Oct 21, 2021

@kikyous, @TylerVigario after installing the fork with the fix I'm getting the following error:

Error: Invalid CSS after "...     floor(math": expected expression (e.g. 1px, bold), was ".div($grid-gutter-w"
        on line 370 of ../../../../../../.rbenv/versions/2.7.4/lib/ruby/gems/2.7.0/bundler/gems/bootstrap3-sass-bbd592141451/assets/stylesheets/bootstrap/_variables.scss
        from line 8 of ../../../../../../.rbenv/versions/2.7.4/lib/ruby/gems/2.7.0/bundler/gems/bootstrap3-sass-bbd592141451/assets/stylesheets/_bootstrap.scss

which seems to be coming from this line. Any ideas on how to fix the issue? I'm using ruby 2.7.4 and rails in version 6.1.4.1.

It is a npm package,not a ruby gem.

@szysza
Copy link

szysza commented Oct 22, 2021

@kikyous, @TylerVigario Thanks for the quick response. npm is just a way of making the package available to use in projects. According to the README of both the forked version and the original one it's possible to use it with ruby on rails. That's they way that I'm using it in the project that I'm working on and it's causing the issue that I've described in my previous comment. Most probably I'll try to experiment with the fork locally and will try to pin point the issue. If you come up with any idea why this issue is happening then I would be grateful.

@TylerVigario
Copy link
Author

TylerVigario commented Oct 22, 2021

@szysza math.div is available only in Dart Sass v1.33 and later. Can you confirm you are using Dart Sass with at least version 1.33?

@fmeyertoens
Copy link

fmeyertoens commented Oct 22, 2021

@kikyous Thank you for forking the repo. Would you mind opening the issue tab on your repo in case of problems like this in the future?

@kikyous
Copy link

kikyous commented Oct 25, 2021

@kikyous Thank you for forking the repo. Would you mind opening the issue tab on your repo in case of problems like this in the future?

OK, issue tab has been opened.

@fmeyertoens

@glebm
Copy link
Member

glebm commented Feb 26, 2022

#1221 was merged instead

@glebm glebm closed this Feb 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants