New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Sass and migrate / to math.div() #1218
Conversation
since this repo is no loger active maintains, i made a npm package use your pr, hope it is usefull install: |
@TylerVigario Is there a plan to merge this? Seeing it all over our projects aswell. |
Use fork from @kikyous above. |
@kikyous, @TylerVigario after installing the fork with the fix I'm getting the following error:
which seems to be coming from this line. Any ideas on how to fix the issue? I'm using ruby 2.7.4 and rails in version 6.1.4.1. |
It is a npm package,not a ruby gem. |
@kikyous, @TylerVigario Thanks for the quick response. npm is just a way of making the package available to use in projects. According to the README of both the forked version and the original one it's possible to use it with ruby on rails. That's they way that I'm using it in the project that I'm working on and it's causing the issue that I've described in my previous comment. Most probably I'll try to experiment with the fork locally and will try to pin point the issue. If you come up with any idea why this issue is happening then I would be grateful. |
@szysza |
@kikyous Thank you for forking the repo. Would you mind opening the issue tab on your repo in case of problems like this in the future? |
OK, issue tab has been opened. |
#1221 was merged instead |
Fix for #1217: Using
/
for division was recently deprecated in Sass.I've updated the source to use
math.div()
and moved to Dart Sass (version 1.33).