Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(theme): update to remove deprecation warning #3404

Merged
merged 5 commits into from Aug 24, 2021

Conversation

jmfrancois
Copy link
Collaborator

@jmfrancois jmfrancois commented Aug 24, 2021

What is the problem this PR is trying to solve?

Following the update of sass compiler we now have lots of deprecation warning.

Screen Shot 2021-08-19 at 11 21 11

Bootstrap has a pull request 1218 to fix that.
We have released this PR under @talend/bootstrap-sass.
we should may be add it in the mono repository for maintainance purpose but for testing purpose I have pushed a fork here which is a fork of this PR integrated.

Because our theme is an overide of bootstrap-sass we have also fix to provide.

What is the chosen solution to this problem?

Provide fix and integrate @talend/bootstrap-sass.
No more deprecation warning in our build logs.

Bonus: fix postcss configuration

Please check if the PR fulfills these requirements

  • The PR have used yarn changeset to a request a release from the CI if wanted.
  • The PR commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features) And non reg done before need review
  • Docs have been added / updated (for bug fixes / features)
  • Related design / discussions / pages (not in jira), if any, are all linked or available in the PR

[ ] This PR introduces a breaking change

@jmfrancois jmfrancois changed the title fix: readd postcss-preset-env fix(theme): update theme to remove deprecation warning Aug 24, 2021
@jmfrancois jmfrancois changed the title fix(theme): update theme to remove deprecation warning fix(theme): update to remove deprecation warning Aug 24, 2021
@github-actions
Copy link
Contributor

3404

:octocat: Demo is available here

@github-actions
Copy link
Contributor

Size Change: +1.49 kB (0%)

Total Size: 2.68 MB

Filename Size Change
./packages/cmf-cqrs/dist/TalendReactCmfCqrs.js.dependencies.json 416 B +192 B (+86%) 🆘
./packages/cmf-cqrs/dist/TalendReactCmfCqrs.min.js.dependencies.json 415 B +191 B (+85%) 🆘
./packages/cmf-router/dist/TalendReactCmfRouter.js.dependencies.json 460 B +109 B (+31%) 🚨
./packages/cmf-router/dist/TalendReactCmfRouter.min.js.dependencies.json 460 B +112 B (+32%) 🚨
./packages/components/dist/TalendReactComponents.js.dependencies.json 772 B +1 B (0%)
./packages/components/dist/TalendReactComponents.min.js.dependencies.json 771 B +1 B (0%)
./packages/containers/dist/TalendReactContainers.js.dependencies.json 605 B +190 B (+46%) 🚨
./packages/containers/dist/TalendReactContainers.min.js.dependencies.json 603 B +185 B (+44%) 🚨
./packages/theme/dist/bootstrap.css 26.8 kB +512 B (+2%)
ℹ️ View Unchanged
Filename Size
./packages/cmf-cqrs/dist/TalendReactCmfCqrs.js 6.37 kB
./packages/cmf-cqrs/dist/TalendReactCmfCqrs.min.js 2.56 kB
./packages/cmf-router/dist/TalendReactCmfRouter.js 10.6 kB
./packages/cmf-router/dist/TalendReactCmfRouter.min.js 3.88 kB
./packages/cmf/dist/TalendReactCmf.js 93.2 kB
./packages/cmf/dist/TalendReactCmf.js.dependencies.json 383 B
./packages/cmf/dist/TalendReactCmf.min.js 31.3 kB
./packages/cmf/dist/TalendReactCmf.min.js.dependencies.json 382 B
./packages/components/dist/TalendReactComponents.css 33.2 kB
./packages/components/dist/TalendReactComponents.js 464 kB
./packages/components/dist/TalendReactComponents.min.js 201 kB
./packages/containers/dist/TalendReactContainers.css 533 B
./packages/containers/dist/TalendReactContainers.js 59.7 kB
./packages/containers/dist/TalendReactContainers.min.js 25.4 kB
./packages/datagrid/dist/TalendReactDatagrid.css 11.4 kB
./packages/datagrid/dist/TalendReactDatagrid.js 60 kB
./packages/datagrid/dist/TalendReactDatagrid.js.dependencies.json 372 B
./packages/datagrid/dist/TalendReactDatagrid.min.js 18.8 kB
./packages/datagrid/dist/TalendReactDatagrid.min.js.dependencies.json 376 B
./packages/dataviz/dist/TalendReactDataviz.css 1.99 kB
./packages/dataviz/dist/TalendReactDataviz.js 210 kB
./packages/dataviz/dist/TalendReactDataviz.js.dependencies.json 303 B
./packages/dataviz/dist/TalendReactDataviz.min.js 184 kB
./packages/dataviz/dist/TalendReactDataviz.min.js.dependencies.json 306 B
./packages/forms/dist/TalendReactForms.css 4.7 kB
./packages/forms/dist/TalendReactForms.js 217 kB
./packages/forms/dist/TalendReactForms.js.dependencies.json 485 B
./packages/forms/dist/TalendReactForms.min.js 115 kB
./packages/forms/dist/TalendReactForms.min.js.dependencies.json 482 B
./packages/http/dist/TalendHttp.js 5.89 kB
./packages/http/dist/TalendHttp.js.dependencies.json 81 B
./packages/http/dist/TalendHttp.min.js 2.2 kB
./packages/http/dist/TalendHttp.min.js.dependencies.json 85 B
./packages/icons/dist/bundle.js 2.4 kB
./packages/icons/dist/info.js 1.96 kB
./packages/icons/dist/react.esm.js 185 kB
./packages/icons/dist/react.js 186 kB
./packages/icons/dist/talend-icons-webfont.css 2.86 kB
./packages/icons/dist/talendicons.css 199 B
./packages/icons/dist/TalendIcons.js 191 kB
./packages/icons/dist/TalendIcons.js.dependencies.json 107 B
./packages/icons/dist/TalendIcons.min.js 188 kB
./packages/icons/dist/TalendIcons.min.js.dependencies.json 109 B
./packages/jsfc/dist/index.js 28.4 kB
./packages/jsfc/dist/index.js.dependencies.json 22 B
./packages/router-bridge/dist/TalendRouterBridge.js 60.3 kB
./packages/router-bridge/dist/TalendRouterBridge.js.dependencies.json 356 B
./packages/router-bridge/dist/TalendRouterBridge.min.js 20.5 kB
./packages/router-bridge/dist/TalendRouterBridge.min.js.dependencies.json 354 B
./packages/sagas/dist/TalendReactSagas.js 2.5 kB
./packages/sagas/dist/TalendReactSagas.js.dependencies.json 168 B
./packages/sagas/dist/TalendReactSagas.min.js 924 B
./packages/sagas/dist/TalendReactSagas.min.js.dependencies.json 170 B
./packages/stepper/dist/TalendReactStepper.js 4.83 kB
./packages/stepper/dist/TalendReactStepper.js.dependencies.json 344 B
./packages/stepper/dist/TalendReactStepper.min.js 1.83 kB
./packages/stepper/dist/TalendReactStepper.min.js.dependencies.json 342 B
./packages/theme/dist/bootstrap.js 1.26 kB
./packages/theme/dist/bootstrap.js.dependencies.json 23 B

compressed-size-action

Copy link
Contributor

@Kporal Kporal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@frassinier frassinier merged commit 2be90ec into master Aug 24, 2021
@frassinier frassinier deleted the jmfrancois/chore/use-fork-theme branch August 24, 2021 15:50
@jmfrancois jmfrancois mentioned this pull request Aug 25, 2021
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants