New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(theme): update to remove deprecation warning #3404
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmfrancois
changed the title
fix: readd postcss-preset-env
fix(theme): update theme to remove deprecation warning
Aug 24, 2021
jmfrancois
changed the title
fix(theme): update theme to remove deprecation warning
fix(theme): update to remove deprecation warning
Aug 24, 2021
frassinier
approved these changes
Aug 24, 2021
Size Change: +1.49 kB (0%) Total Size: 2.68 MB
ℹ️ View Unchanged
|
Kporal
approved these changes
Aug 24, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem this PR is trying to solve?
Following the update of sass compiler we now have lots of deprecation warning.
Bootstrap has a pull request 1218 to fix that.
We have released this PR under @talend/bootstrap-sass.
we should may be add it in the mono repository for maintainance purpose but for testing purpose I have pushed a fork here which is a fork of this PR integrated.
Because our theme is an overide of bootstrap-sass we have also fix to provide.
What is the chosen solution to this problem?
Provide fix and integrate @talend/bootstrap-sass.
No more deprecation warning in our build logs.
Bonus: fix postcss configuration
Please check if the PR fulfills these requirements
yarn changeset
to a request a release from the CI if wanted.[ ] This PR introduces a breaking change