Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #70

Merged
merged 1 commit into from Jun 11, 2018
Merged

Update dependencies #70

merged 1 commit into from Jun 11, 2018

Conversation

bjornstar
Copy link
Contributor

  • To avoid complaints from npm audit I updated all the dependencies (fixes Update unsecure dependency #69)
  • Replaced gulp with simple npm scripts: lint & mocha
  • Updated the tested node versions to the three modern versions: 6, 8 & 10
  • Updated the README to document the change from gulp to npm scripts
  • Replaced istanbul with nyc (it's the same project)
  • Updated the minimum node version to 6
  • Regenerated docs (there was an issue with one of the links so I tweaked it to match the other links)
  • Removed unused, deprecated eslint option: ecmaFeatures

@bjornstar
Copy link
Contributor Author

Is there anything I can do to get this looked at?

@bjornstar
Copy link
Contributor Author

Any interest in moving forward with this?

@oliverjessner
Copy link

Sadly it looks like the tumblr team is not very active :(

@ceyko
Copy link
Contributor

ceyko commented Jun 8, 2018

Hey @bjornstar this looks great, thanks!

Only thing we need from you now to merge this is to accept our CLA. I don't see one currently on file for your github user, so can you please visit https://yahoocla.herokuapp.com/ and agree to the terms? Thanks! :)

@yahoocla
Copy link

yahoocla commented Jun 8, 2018

Thank you for submitting this pull request, however I do not see a valid CLA on file for you. Before we can merge this request please visit https://yahoocla.herokuapp.com/ and agree to the terms. Thanks! 😄

@bjornstar
Copy link
Contributor Author

Thanks! I just signed the CLA.

@ceyko ceyko merged commit ec917af into tumblr:master Jun 11, 2018
@bjornstar bjornstar deleted the bump-dependencies branch April 12, 2021 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update unsecure dependency
4 participants