Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update compatible node versions #67

Closed
wants to merge 1 commit into from
Closed

Update compatible node versions #67

wants to merge 1 commit into from

Conversation

jasonpenny
Copy link
Contributor

This other PR is failing to build on a very old version of node: #66

This PR stops travis-ci from trying to build very old versions and bumps the major version number since we are effectively removing support for 0.12

This follows the very popular request library:
https://github.com/request/request/blob/master/.travis.yml#L4-L8

@ceyko

@jasonpenny jasonpenny requested a review from ceyko April 27, 2018 18:21
@ceyko
Copy link
Contributor

ceyko commented Jun 13, 2018

This was added as part of #70

@ceyko ceyko closed this Jun 13, 2018
ceyko added a commit that referenced this pull request Jun 13, 2018
@ceyko
Bump version to 2.0.0
3aec27b 
As mentioned in #67, since we've dropped support for a (very) old
version of node - 0.12, we should bump the major version.

See: #67
@ceyko ceyko mentioned this pull request Jun 13, 2018
Merged
@jasonpenny jasonpenny deleted the update-travisci branch June 13, 2018 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ceyko ceyko Awaiting requested review from ceyko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jasonpenny @ceyko