Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Differentiate KafkaMessage type between Record and Message #1401

Merged
merged 2 commits into from
Jun 28, 2022
Merged

Differentiate KafkaMessage type between Record and Message #1401

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c360613
Fix invalid KafkaMessage type
Nevon Jun 22, 2022
e1b016e
Make it possible to narrow between message types
Nevon Jun 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
16 changes: 14 additions & 2 deletions types/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -631,16 +631,28 @@ export type Broker = {
}): Promise<any>
}

export type KafkaMessage = {
interface MessageSetEntry {
key: Buffer | null
value: Buffer | null
timestamp: string
attributes: number
offset: string
size: number
headers?: never
}

interface RecordBatchEntry {
key: Buffer | null
value: Buffer | null
timestamp: string
attributes: number
offset: string
headers?: IHeaders
headers: IHeaders
size?: never
}

export type KafkaMessage = MessageSetEntry | RecordBatchEntry

export interface ProducerRecord {
topic: string
messages: Message[]
Expand Down