Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Differentiate KafkaMessage type between Record and Message #1401

Merged
merged 2 commits into from
Jun 28, 2022
Merged

Differentiate KafkaMessage type between Record and Message #1401

merged 2 commits into from
Jun 28, 2022

Commits on Jun 28, 2022

  1. Fix invalid KafkaMessage type 

    The `size` attribute is only ever present on pre-0.10 `Messages`,
and never on the new `Record`. The field was mistakenly defined as
being non-optional.

Providing a meaningful `size` field for Record is tricky because in
RecordBatch all the records are compressed together, rather than individually
as is the case with the old Message protocol. Therefore you can only
calculate a size for the uncompressed record, which isn't very useful
since you most likely care about the size because you want to understand
the size over the network.
    @Nevon
    Nevon committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    c360613 View commit details
    Browse the repository at this point in the history

  2. Make it possible to narrow between message types

    @Nevon
    Nevon committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    e1b016e View commit details
    Browse the repository at this point in the history