New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add configuration parsing and custom detectors to engine #968
Merged
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
package config | ||
|
||
import ( | ||
"os" | ||
|
||
"github.com/trufflesecurity/trufflehog/v3/pkg/custom_detectors" | ||
"github.com/trufflesecurity/trufflehog/v3/pkg/detectors" | ||
"github.com/trufflesecurity/trufflehog/v3/pkg/pb/custom_detectorspb" | ||
"github.com/trufflesecurity/trufflehog/v3/pkg/protoyaml" | ||
) | ||
|
||
// Config holds user supplied configuration. | ||
type Config struct { | ||
Detectors []detectors.Detector | ||
} | ||
|
||
// Read parses a given filename into a Config. | ||
func Read(filename string) (*Config, error) { | ||
if filename == "" { | ||
return &Config{}, nil | ||
} | ||
input, err := os.ReadFile(filename) | ||
if err != nil { | ||
return nil, err | ||
} | ||
return NewYAML(input) | ||
} | ||
|
||
// NewYAML parses the given YAML data into a Config. | ||
func NewYAML(input []byte) (*Config, error) { | ||
// Parse the raw YAML into a structure. | ||
var messages custom_detectorspb.CustomDetectors | ||
if err := protoyaml.UnmarshalStrict(input, &messages); err != nil { | ||
return nil, err | ||
} | ||
// Convert the structured YAML into detectors. | ||
var detectors []detectors.Detector | ||
for _, detectorConfig := range messages.Detectors { | ||
detector, err := custom_detectors.NewWebhookCustomRegex(detectorConfig) | ||
if err != nil { | ||
return nil, err | ||
} | ||
detectors = append(detectors, detector) | ||
} | ||
return &Config{ | ||
Detectors: detectors, | ||
}, nil | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
optional: I feel like this should return an error instead of an empty config. Because an empty filename string would occur anytime
--config
is included but nothing follows it, yeah? (At least I think it would?) Which seems like an accident we should tell the user about, rather than intentionally adding an empty config.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm.. that's a good point. I'll have to see if there's a way to differentiate between
--config ''
and no flag, because currently I think they both return""
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found there's an
ExistingFile()
method in kingpin which will do the job. Now--config ''
will error and no flag will not.