Add configuration parsing and custom detectors to engine #968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Waiting on #950 to be merged. |
mcastorina
force-pushed
the
thog-807-custom-regex-engine
branch
from
2d4cdfc
to
a159c70
Compare
trufflesteeeve
approved these changes
Dec 20, 2022
pkg/config/config.go
Outdated
| // Read parses a given filename into a Config. | ||
| func Read(filename string) (*Config, error) { | ||
| if filename == "" { | ||
| return &Config{}, nil |
There was a problem hiding this comment.
optional: I feel like this should return an error instead of an empty config. Because an empty filename string would occur anytime --config is included but nothing follows it, yeah? (At least I think it would?) Which seems like an accident we should tell the user about, rather than intentionally adding an empty config.
There was a problem hiding this comment.
Hm.. that's a good point. I'll have to see if there's a way to differentiate between --config '' and no flag, because currently I think they both return "".
There was a problem hiding this comment.
Found there's an ExistingFile() method in kingpin which will do the job. Now --config '' will error and no flag will not.
javajawa
added a commit
to mewbotorg/mewbot
that referenced
this pull request
Dec 26, 2022
Update trufflehog from 3.19.0 to 3.21.0. - Bump github.com/xanzy/go-gitlab from 0.76.0 to 0.77.0 by @dependabot in trufflesecurity/trufflehog#981 - Bump golang.org/x/crypto from 0.3.0 to 0.4.0 by @dependabot in trufflesecurity/trufflehog#982 - Add configuration parsing and custom detectors to engine by @mcastorina in trufflesecurity/trufflehog#968 - Add custom regex detector docs by @mcastorina in trufflesecurity/trufflehog#983 - Remove custom log leveler by @mcastorina in trufflesecurity/trufflehog#985 - Bump github.com/xanzy/go-gitlab from 0.74.0 to 0.76.0 by @dependabot in trufflesecurity/trufflehog#934 - Bump github.com/bill-rich/disk-buffer-reader from v0.1.6 to v0.1.7 by @bill-rich in trufflesecurity/trufflehog#970 - Bump go.mongodb.org/mongo-driver from 1.11.0 to 1.11.1 by @dependabot in trufflesecurity/trufflehog#971 - Bump github.com/getsentry/sentry-go from 0.15.0 to 0.16.0 by @dependabot in trufflesecurity/trufflehog#973 - [bug] - Handle error when scanning s3 bucket. by @ahrav in trufflesecurity/trufflehog#969 - Bump github.com/go-git/go-git/v5 from 5.4.2 to 5.5.1 by @dependabot in trufflesecurity/trufflehog#972 - Bump github.com/envoyproxy/protoc-gen-validate from 0.6.13 to 0.9.1 by @dependabot in trufflesecurity/trufflehog#963 - Add more logging for git sources by @mcastorina in trufflesecurity/trufflehog#974 - Add s3 object count to trace logs by @bill-rich in trufflesecurity/trufflehog#975 - Implement CustomRegex detector by @mcastorina in trufflesecurity/trufflehog#950 - Use Todoist's REST API v2 by @goncalossilva in trufflesecurity/trufflehog#978 - Allow using a glob for include list. by @ahrav in trufflesecurity/trufflehog#977
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.