Add table statistics and automatic Join pushdown for SQL Server connector #11637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Currently based on #11635 |
findepi
force-pushed
the
findepi/rdbms-stats-sqlserver
branch
from
02001be
to
f35810b
Compare
|
rebased after #11635 merged |
hashhar
reviewed
Mar 25, 2022
| @Override | ||
| protected void checkEmptyTableStats(String tableName) | ||
| { | ||
| // TODO: Empty tables should have NDV as 0 and nulls fraction as 1 (https://starburstdata.atlassian.net/browse/SEP-5963) |
There was a problem hiding this comment.
rmeoving link, leaving the comment
...in/trino-sqlserver/src/test/java/io/trino/plugin/sqlserver/TestSqlServerTableStatistics.java
Show resolved
Hide resolved
...in/trino-sqlserver/src/test/java/io/trino/plugin/sqlserver/TestSqlServerTableStatistics.java
Outdated
Show resolved
Hide resolved
...in/trino-sqlserver/src/test/java/io/trino/plugin/sqlserver/TestSqlServerTableStatistics.java
Outdated
Show resolved
Hide resolved
findepi
force-pushed
the
findepi/rdbms-stats-sqlserver
branch
from
f35810b
to
4660968
Compare
|
( just rebased ) |
findepi
force-pushed
the
findepi/rdbms-stats-sqlserver
branch
from
4660968
to
0a2ae91
Compare
hashhar
approved these changes
Apr 1, 2022
losipiuk
approved these changes
Apr 1, 2022
findepi
force-pushed
the
findepi/rdbms-stats-sqlserver
branch
from
2ca822a
to
3045084
Compare
|
In https://github.com/trinodb/trino/runs/5784397964?check_suite_focus=true the SQL Server tests crashed. |
findepi
commented
Apr 6, 2022
| Project's default for air.test.parallel is 'methods'. By design, 'classes' makes TestNG run tests from one class in a single thread. | ||
| As a side effect, it prevents TestNG from initializing multiple test instances upfront, which happens with 'methods'. | ||
| A potential downside can be long tail single-threaded execution of a single long test class. | ||
| TODO (https://github.com/trinodb/trino/issues/11294) remove when we upgrade to surefire with https://issues.apache.org/jira/browse/SUREFIRE-1967 |
This is supposed to workaround OOM problems when multiple test instances are initialized. This seems to be prerequisite if we want to add more QueryRunner-based tests.
findepi
force-pushed
the
findepi/rdbms-stats-sqlserver
branch
from
3045084
to
909b3ca
Compare
|
( just rebased, to resolve conflicts in ci.yml ) |
|
stress tests awesomely green; sqlserver x20 https://github.com/trinodb/trino/runs/5858695489?check_suite_focus=true |
findepi
force-pushed
the
findepi/rdbms-stats-sqlserver
branch
from
c16a613
to
786b693
Compare
|
( dropped stress tests ) |
hashhar
approved these changes
Apr 8, 2022
ebyhr
approved these changes
Apr 8, 2022
Closed
This was referenced Apr 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.