Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up join pushdown docs for JDBC connectors #11967

Merged
merged 1 commit into from
Apr 15, 2022

Conversation

jhlodin
Copy link
Contributor

@jhlodin jhlodin commented Apr 14, 2022

Description

With table statistics & cost-based join pushdowns added to select JDBC connectors, the join-pushdown.enabled property which previously defaulted to false on all JDBC connectors now defaults to true in these select connectors. This PR updates adds doc fragments that now accurately describe this property and its default value on a per-connector basis, as well as the needed title level and structure consistency changes needed to implement this improvement.

Is this change a fix, improvement, new feature, refactoring, or other?

Improvement

Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific)

Documentation

How would you describe this change to a non-technical end user or system administrator?

Make the join pushdown documentation consistent across connectors, while adding corrected information on how to configure join pushdown on JDBC connectors

Related issues, pull requests, and links

Documentation

( ) No documentation is needed.
(x) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.

Release notes

(x) No release notes entries required.
( ) Release notes entries required with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor correction .. the rest looks good.

@hashhar hashhar merged commit b7d7252 into trinodb:master Apr 15, 2022
@github-actions github-actions bot added this to the 378 milestone Apr 15, 2022
@jhlodin jhlodin deleted the jl/join-pushdown-prop branch April 15, 2022 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants