Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update jaeger-client-go dependency to v2.25.0 #7198

Merged
merged 2 commits into from Aug 19, 2020
Merged

Update jaeger-client-go dependency to v2.25.0 #7198

merged 2 commits into from Aug 19, 2020

Conversation

kevinpollet
Copy link
Member

@kevinpollet kevinpollet commented Aug 19, 2020 •
edited by ldez

What does this PR do?

This PR updates the jaeger-client-go dependency version to v2.25.0.

This update allows the reconnection to the jaeger-agent when the connection is lost. As this new behaviour is listed as breaking in v2.25.0 a new tracing option for jaeger named DisableAttemptReconnecting defaulting to true has been introduced to be backward compatible.

Motivation

Fixes #6093

More

  • [ ] Added/updated tests
  • Added/updated documentation

Additional Notes

ldez
ldez approved these changes Aug 19, 2020
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez added bot/light-review decreases the number of required LGTM from 3 to 1. status/2-needs-review and removed status/0-needs-triage labels Aug 19, 2020
@ldez ldez added this to To review in v2 via automation Aug 19, 2020
@ldez ldez added this to the 2.3 milestone Aug 19, 2020
@traefiker traefiker merged commit 584f4bc into traefik:v2.3 Aug 19, 2020
v2 automation moved this from To review to Done Aug 19, 2020
@traefiker traefiker removed bot/light-review decreases the number of required LGTM from 3 to 1. status/3-needs-merge labels Aug 19, 2020
@rtribotte rtribotte added the kind/bug/fix a bug fix label Aug 19, 2020
@kevinpollet kevinpollet mentioned this pull request Aug 20, 2020
Merged
@ldez ldez mentioned this pull request Aug 20, 2020
Closed
@kevinpollet kevinpollet deleted the issue-6093 branch August 20, 2020 20:02
@kevinpollet kevinpollet mentioned this pull request Oct 2, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldez ldez ldez approved these changes

Assignees
No one assigned
Labels
area/middleware/tracing kind/bug/fix a bug fix size/S
Projects
No open projects
v2
Done
Milestone
2.3
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kevinpollet @ldez @rtribotte @traefiker