Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove init container used to wait for jaeger init #707

Merged
merged 3 commits into from Aug 21, 2020
Merged

Remove init container used to wait for jaeger init #707

merged 3 commits into from Aug 21, 2020

Conversation

kevinpollet
Copy link
Member

What does this PR do?

This PR:

  • Adds the type field to the Helm chart descriptor
  • Removes the unsupported engine property from the Helm chart descriptor
  • Removes the init container used to wait for the Jaeger service to be ready as of Traefik v2.3-rc4 the Jaeger client will attempt to reconnect.

How to test it

  • Install Maesh with Helm
  • Install a whoami service
  • Make a request and check that the Uber-Trace-Id header is here.

@kevinpollet kevinpollet added this to the v1.4 milestone Aug 20, 2020
jspdown
jspdown approved these changes Aug 21, 2020
View reviewed changes
Copy link
Contributor

@jspdown jspdown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@traefiker traefiker merged commit 61c8be6 into traefik:master Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jspdown jspdown jspdown approved these changes

Assignees
No one assigned
Labels
area/helm area/tracing kind/enhancement a new or improved feature.
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kevinpollet @jspdown @traefiker