Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

contrib.concurrent: Use python default max_workers #1543

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

contrib.concurrent: Use python default max_workers #1543

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8946047
Use python default max_workers for concurrent.futures executors
aripollak Dec 28, 2023
9c6c469
Remove default: None in comment
aripollak Dec 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 2 additions & 5 deletions tqdm/contrib/concurrent.py
View file
Open in desktop
Expand Up @@ -3,7 +3,6 @@
"""
from contextlib import contextmanager
from operator import length_hint
from os import cpu_count

from ..auto import tqdm as tqdm_auto
from ..std import TqdmWarning
Expand Down Expand Up @@ -33,15 +32,15 @@ def _executor_map(PoolExecutor, fn, *iterables, **tqdm_kwargs):
Parameters
----------
tqdm_class : [default: tqdm.auto.tqdm].
max_workers : [default: min(32, cpu_count() + 4)].
max_workers : [default: None].
chunksize : [default: 1].
lock_name : [default: "":str].
"""
kwargs = tqdm_kwargs.copy()
if "total" not in kwargs:
kwargs["total"] = length_hint(iterables[0])
tqdm_class = kwargs.pop("tqdm_class", tqdm_auto)
max_workers = kwargs.pop("max_workers", min(32, cpu_count() + 4))
max_workers = kwargs.pop("max_workers", None)
chunksize = kwargs.pop("chunksize", 1)
lock_name = kwargs.pop("lock_name", "")
with ensure_lock(tqdm_class, lock_name=lock_name) as lk:
Expand All @@ -63,7 +62,6 @@ def thread_map(fn, *iterables, **tqdm_kwargs):
max_workers : int, optional
Maximum number of workers to spawn; passed to
`concurrent.futures.ThreadPoolExecutor.__init__`.
[default: max(32, cpu_count() + 4)].
"""
from concurrent.futures import ThreadPoolExecutor
return _executor_map(ThreadPoolExecutor, fn, *iterables, **tqdm_kwargs)
Expand All @@ -81,7 +79,6 @@ def process_map(fn, *iterables, **tqdm_kwargs):
max_workers : int, optional
Maximum number of workers to spawn; passed to
`concurrent.futures.ProcessPoolExecutor.__init__`.
[default: min(32, cpu_count() + 4)].
chunksize : int, optional
Size of chunks sent to worker processes; passed to
`concurrent.futures.ProcessPoolExecutor.map`. [default: 1].
Expand Down