contrib.concurrent: Use python default max_workers #1543
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that contrib.concurrent defines its own default for max_workers, which is the same as CPython's default for ThreadPoolExecutor in CPython 3.8+, but differs from the default for ProcessPoolExecutor:
This was surprising to me. If the running code is CPU-bound, which is usually why you'd use
process_map
instead ofthread_map
, there usually isn't a noticeable speed improvement to spawn more processes than the number of available CPUs. In my case,cpu_count + 4
ended up using more RAM than necessary for maximum speed improvement. I'm using a package that loads an index into memory at 800 MB per process, so that's an unnecessary extra 3.2 GB used by default.Obsoletes #1530.