Render nested progress bars in the same container in IPython. #1504
+27
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UFO-101
force-pushed
the
master
branch
2 times, most recently
from
24ddfa7
to
e202621
Compare
UFO-101
force-pushed
the
master
branch
5 times, most recently
from
b2a3c59
to
e8a0a28
Compare
|
@casperdcl is this reviewable? I'd really like to consume this fix for VS Code |
Closed
2 tasks
|
Any way to make it merged to mainline? It is pretty annoying visual bug which pollutes whole notebook in just few minutes... |
|
Any news on this? it would be amazing not to have this bug! |
|
Still no news? Seems that it has been stuck in review for quite a while by now... |
|
+1 This should be merged as soon as reasonably possible |
…endering issues in VSCode. See issue: microsoft/vscode-jupyter#9397. Also fixes leave=None in IPython. As per the documentation, setting leave=None should leave iff position=0, but currently it is just equivalent to leave=False.
|
I've released a fork of tqdm with this fix on PyPI: https://pypi.org/project/vscode-tqdm/ |
|
But yeah this should really just be merged. |
|
@UFO-101 Thanks for your work on this. Using your version until @casperdcl has an opportunity to review and hopefully approve. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes rendering issues in VSCode: microsoft/vscode-jupyter#9397.
BEFORE:
Screen.Recording.2023-08-27.at.17.44.10.mov
AFTER:
Screen.Recording.2023-08-27.at.17.40.56.mov
Yes it's unclear who's fault this is, but it doesn't seem like anyone else is going to fix it anytime soon and this way seems fine anyway.