Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tqdm unable to remove progress bar widgets – blank vertical space left in the output container #9397

Open
aldanor opened this issue Mar 16, 2022 · 18 comments
Open

tqdm unable to remove progress bar widgets – blank vertical space left in the output container #9397

aldanor opened this issue Mar 16, 2022 · 18 comments
Assignees
@DonJayamanne
Labels
bug Issue identified by VS Code Team member as probable bug ipywidgets Rendering, loading, saving, anything to do with IPyWidgets upstream-vscode Blocked on upstream VS code
Milestone
Backlog

Comments

@aldanor
Copy link

aldanor commented Mar 16, 2022

Environment data

  • VS Code version: 1.65.2
  • Jupyter Extension version: v2022.2.1030672458
  • Python Extension version: v2022.2.1924087327
  • macOS 10.15.7
  • Python 3.9, conda
  • Jupyter server: local

Observed behaviour

2022-03-16_23-37-09.mp4

Expected behaviour

No blank vertical space is left.

Related

tqdm/tqdm#1287
@aldanor aldanor added the bug Issue identified by VS Code Team member as probable bug label Mar 16, 2022
@IanMatthewHuff
Copy link
Member

Hmm, I'm looking at this right now in vscode-insiders (which has all our newest bits) I'm seeing something slightly different.
TQDM
Here I don't see the extra lines, but I also don't see the second and third passes of the 10 size loop.

Does seem like there is some type of issue though. Thanks for the report on this.

@IanMatthewHuff
Copy link
Member

Just for our validation here is what I would expect to see:
TQDMJupyter

@IanMatthewHuff IanMatthewHuff removed their assignment Mar 17, 2022
@DonJayamanne DonJayamanne added ipywidgets Rendering, loading, saving, anything to do with IPyWidgets and removed needs-triage labels Mar 17, 2022
@DonJayamanne
Copy link
Contributor

This looks like a bug in VS Code, I'm seeing a lot of weird behaviors

  • Basically sometimes the 2nd progress is not visible (but when i scroll or add a new cell it magically appears)
  • The output Done is not displayed at the end (but when i scroll or add a new cell it magically appears)

@DonJayamanne DonJayamanne self-assigned this Mar 23, 2022
@rebornix rebornix mentioned this issue Mar 29, 2022
Closed
@DonJayamanne
Copy link
Contributor

This should now be fixed in the latest insider version of VS Code and Jupyter extension

@DonJayamanne DonJayamanne added this to the April 2022 milestone Apr 11, 2022
@rchiodo
Copy link
Contributor

rchiodo commented Apr 28, 2022

It's better but still not fixed. I'll reopen the vscode bug too.

Here's what I get:
tqdm

Compare that to jupyter and you can see we end up with extra blank lines.

@rchiodo rchiodo reopened this Apr 28, 2022
@greazer greazer added upstream-vscode Blocked on upstream VS code and removed needs-triage labels Apr 28, 2022
@greazer greazer modified the milestones: April 2022, May 2022 Apr 28, 2022
@rebornix
Copy link
Member

rebornix commented May 5, 2022

@rchiodo it doesn't seem to be an issue with rendering, if you check the document after saving it, you would see for every blank line is actually a widget output. VS Code is rendering them as expected.

@rebornix rebornix closed this as completed May 5, 2022
@rebornix rebornix reopened this May 5, 2022
@github-actions github-actions bot added the triage-needed Issue needs to be triaged label May 5, 2022
@greazer greazer added discuss-at-standup and removed triage-needed Issue needs to be triaged labels May 5, 2022
@DonJayamanne DonJayamanne removed their assignment May 16, 2022
@DonJayamanne DonJayamanne modified the milestones: March 2023, April 2023 Mar 21, 2023
@DonJayamanne DonJayamanne modified the milestones: April 2023, May 2023 Apr 26, 2023
@sdesrozis
Copy link

Any update on this ?

UFO-101 added a commit to UFO-101/tqdm that referenced this issue Aug 27, 2023
@UFO-101
Render nested progress bars in the same container in IPython. Fixes r…
6bf8b3a 
…endering issues in VSCode: microsoft/vscode-jupyter#9397.
UFO-101 added a commit to UFO-101/tqdm that referenced this issue Aug 27, 2023
@UFO-101
Render nested progress bars in the same container in IPython. Fixes r…
d832c33 
…endering issues in VSCode: microsoft/vscode-jupyter#9397.
UFO-101 added a commit to UFO-101/tqdm that referenced this issue Aug 27, 2023
@UFO-101
Render nested progress bars in the same container in IPython. Fixes r…
c58aa35 
…endering issues in VSCode: microsoft/vscode-jupyter#9397.
@UFO-101 UFO-101 mentioned this issue Aug 27, 2023
Open
UFO-101 added a commit to UFO-101/tqdm that referenced this issue Aug 27, 2023
@UFO-101
Render nested progress bars in the same container in IPython. Fixes r…
24ddfa7 
…endering issues in VSCode. See: microsoft/vscode-jupyter#9397.
UFO-101 added a commit to UFO-101/tqdm that referenced this issue Aug 27, 2023
@UFO-101
Render nested progress bars in the same container in IPython. Fixes r…
e202621 
…endering issues in VSCode. See issue: microsoft/vscode-jupyter#9397.
@UFO-101
Copy link

UFO-101 commented Aug 27, 2023

Opened a PR in tqdm to work around this: tqdm/tqdm#1504
In the meantime you can use https://github.com/UFO-101/tqdm.git as a depedency.

UFO-101 added a commit to UFO-101/tqdm that referenced this issue Aug 27, 2023
@UFO-101
Render nested progress bars in the same container in IPython. Fixes r…
b5d42c0 
…endering issues in VSCode. See issue: microsoft/vscode-jupyter#9397.
UFO-101 added a commit to UFO-101/tqdm that referenced this issue Aug 27, 2023
@UFO-101
Render nested progress bars in the same container in IPython. Fixes r…
a76a506 
…endering issues in VSCode. See issue: microsoft/vscode-jupyter#9397.
UFO-101 added a commit to UFO-101/tqdm that referenced this issue Aug 28, 2023
@UFO-101
Render nested progress bars in the same container in IPython. Fixes r…
2f9588f 
…endering issues in VSCode. See issue: microsoft/vscode-jupyter#9397.

Also fixes leave=None in IPython. As per the documentation, setting leave=None should leave iff position=0, but currently it is just equivalent to leave=False.
UFO-101 added a commit to UFO-101/tqdm that referenced this issue Aug 28, 2023
@UFO-101
Render nested progress bars in the same container in IPython. Fixes r…
b2a3c59 
…endering issues in VSCode. See issue: microsoft/vscode-jupyter#9397.

Also fixes leave=None in IPython. As per the documentation, setting leave=None should leave iff position=0, but currently it is just equivalent to leave=False.
UFO-101 added a commit to UFO-101/tqdm that referenced this issue Aug 28, 2023
@UFO-101
Render nested progress bars in the same container in IPython. Fixes r…
e8a0a28 
…endering issues in VSCode. See issue: microsoft/vscode-jupyter#9397.

Also fixes leave=None in IPython. As per the documentation, setting leave=None should leave iff position=0, but currently it is just equivalent to leave=False.
@Royal-lobster Royal-lobster mentioned this issue Nov 2, 2023
Closed
@DonJayamanne DonJayamanne mentioned this issue Nov 22, 2023
Closed
2 tasks
@DonJayamanne DonJayamanne added this to the Backlog milestone Dec 4, 2023
UFO-101 added a commit to UFO-101/tqdm that referenced this issue Apr 28, 2024
@UFO-101
Render nested progress bars in the same container in IPython. Fixes r…
bd9f7d6 
…endering issues in VSCode. See issue: microsoft/vscode-jupyter#9397.

Also fixes leave=None in IPython. As per the documentation, setting leave=None should leave iff position=0, but currently it is just equivalent to leave=False.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DonJayamanne DonJayamanne

Labels
bug Issue identified by VS Code Team member as probable bug ipywidgets Rendering, loading, saving, anything to do with IPyWidgets upstream-vscode Blocked on upstream VS code
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests