ci: run MSRV checks with minimal dep versions #670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In many cases, new releases of a dependency can break compatibility with Tower's minimum supported Rust version (MSRV). It shouldn't be necessary for Tower to bump its MSRV when a dependency does, as users on older Rust versions should be able to depend on older versions of that crate. Instead, we should probably just run our MSRV checks with minimal dependency versions. This branch changes Tower's CI jobs to do that. Signed-off-by: Eliza Weisman <eliza@buoyant.io>
olix0r
approved these changes
Jun 17, 2022
LucioFranco
approved these changes
Jun 17, 2022
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
|
Oh. Nevermind. We can't do this, because |
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
olix0r
reviewed
Jun 17, 2022
this fixes the minimal version build Signed-off-by: Eliza Weisman <eliza@buoyant.io>
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
see https://github.com/tokio-rs/tokio/blob/master/tokio/CHANGELOG.md#162-june-14-2021 Signed-off-by: Eliza Weisman <eliza@buoyant.io>
i hate this but whatever lol Signed-off-by: Eliza Weisman <eliza@buoyant.io>
hawkw
added a commit
that referenced
this pull request
Jun 17, 2022
In many cases, new releases of a dependency can break compatibility with Tower's minimum supported Rust version (MSRV). It shouldn't be necessary for Tower to bump its MSRV when a dependency does, as users on older Rust versions should be able to depend on older versions of that crate. Instead, we should probably just run our MSRV checks with minimal dependency versions. This branch changes Tower's CI jobs to do that. It was also necessary to make some changes to the `Cargo.toml` to actually fix the build with minimal dependency versions. Signed-off-by: Eliza Weisman <eliza@buoyant.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In many cases, new releases of a dependency can break compatibility with
Tower's minimum supported Rust version (MSRV). It shouldn't be necessary
for Tower to bump its MSRV when a dependency does, as users on older
Rust versions should be able to depend on older versions of that crate.
Instead, we should probably just run our MSRV checks with minimal
dependency versions.
This branch changes Tower's CI jobs to do that.
Signed-off-by: Eliza Weisman eliza@buoyant.io