Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: run MSRV checks with minimal dep versions #670

Merged
merged 10 commits into from Jun 17, 2022
Merged

ci: run MSRV checks with minimal dep versions #670

merged 10 commits into from Jun 17, 2022

Commits on Jun 17, 2022

  1. ci: run MSRV checks with minimal dep versions 

    In many cases, new releases of a dependency can break compatibility with
Tower's minimum supported Rust version (MSRV). It shouldn't be necessary
for Tower to bump its MSRV when a dependency does, as users on older
Rust versions should be able to depend on older versions of that crate.
Instead, we should probably just run our MSRV checks with minimal
dependency versions.

This branch changes Tower's CI jobs to do that.

Signed-off-by: Eliza Weisman <eliza@buoyant.io>
    @hawkw
    hawkw committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    18e1ffb View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into eliza/msrv-min-versions

    @hawkw
    hawkw committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    72a83d9 View commit details
    Browse the repository at this point in the history

  3. fixup! depend on correct jobs 

    Signed-off-by: Eliza Weisman <eliza@buoyant.io>
    @hawkw
    hawkw committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    b92d074 View commit details
    Browse the repository at this point in the history

  4. maybe this will work 

    Signed-off-by: Eliza Weisman <eliza@buoyant.io>
    @hawkw
    hawkw committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    b702718 View commit details
    Browse the repository at this point in the history

  5. disable hdrhistogram's default features 

    this fixes the minimal version build

Signed-off-by: Eliza Weisman <eliza@buoyant.io>
    @hawkw
    hawkw committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    213453a View commit details
    Browse the repository at this point in the history

  6. also let nightly cargo run the fetch 

    Signed-off-by: Eliza Weisman <eliza@buoyant.io>
    @hawkw
    hawkw committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    c803a31 View commit details
    Browse the repository at this point in the history

  7. let msrv cargo fetch deps 

    Signed-off-by: Eliza Weisman <eliza@buoyant.io>
    @hawkw
    hawkw committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    a1e52a4 View commit details
    Browse the repository at this point in the history

  8. use tracing-subscriber 0.3 in tests 

    Signed-off-by: Eliza Weisman <eliza@buoyant.io>
    @hawkw
    hawkw committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    617f183 View commit details
    Browse the repository at this point in the history

  9. tests fail on tokio 1.6.1 due to timer bug 

    see https://github.com/tokio-rs/tokio/blob/master/tokio/CHANGELOG.md#162-june-14-2021

Signed-off-by: Eliza Weisman <eliza@buoyant.io>
    @hawkw
    hawkw committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    669ba18 View commit details
    Browse the repository at this point in the history

  10. explicitly use a non-messed-up lazy-static dev dep 

    i hate this but whatever lol

Signed-off-by: Eliza Weisman <eliza@buoyant.io>
    @hawkw
    hawkw committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    2a0e586 View commit details
    Browse the repository at this point in the history