Bump MSRV to 1.56 and update to the 2021 edition #1098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We could do something like tower-rs/tower#670 but I still bumping our MSRV is fine |
jplatte
approved these changes
Jun 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI builds are failing because a dependency updated to the latest
hashbrownwhich uses the 2021 edition. That isn't available in our MSRV which is 1.54. I've been reluctant to bump our MSRV without a good reason but IMO this is a good reason. Not quite sure how else to resolve it, without pinning to specific versions of crates which is a hassle.1.56 came up in October 2021 so thats like 8 months which I think is reasonable.
I don't consider this a breaking change.
All the changes were done with search and replace. There are probably some places in the code that could be moved to newer features but we can do that in follow up PRs when we come across them.