Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump iri-string to 0.7.0 and use shorter type names #312

Merged
merged 1 commit into from
Dec 2, 2022

Conversation

lo48576
Copy link
Contributor

@lo48576 lo48576 commented Dec 2, 2022

This PR bumps the internal dependency to iri-string crate to the latest stable version.

(Disclaimer: I am the author of iri-string crate.)

This is retry of #225.

Motivation

  • Better performance
  • Reduced indirect dependencies

Solution

Bump the dependency to iri-string from 0.4.0 to 0.7.0.

Copy link
Member

@davidpdrsn davidpdrsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet! Thanks!

@davidpdrsn davidpdrsn enabled auto-merge (squash) December 2, 2022 13:41
@lo48576
Copy link
Contributor Author

lo48576 commented Dec 2, 2022

The test failure for "CI / check (pull_request)" https://github.com/tower-rs/tower-http/actions/runs/3602117978/jobs/6068850376 does not seem to be caused by this PR.

@davidpdrsn
Copy link
Member

Yeah thats definitely unrelated. Probably caused by a merge that didn't have conflicts but didn't compile either. I'll fix that!

@davidpdrsn
Copy link
Member

@lo48576 should be fixed if you merge the latest master.

auto-merge was automatically disabled December 2, 2022 15:28

Head branch was pushed to by a user without write access

@lo48576 lo48576 force-pushed the feature/bump-iri-string-to-0-7 branch from 0b0b208 to 1a2e506 Compare December 2, 2022 15:28
@davidpdrsn davidpdrsn enabled auto-merge (squash) December 2, 2022 15:36
@davidpdrsn davidpdrsn merged commit fa94ba0 into tower-rs:master Dec 2, 2022
@lo48576 lo48576 deleted the feature/bump-iri-string-to-0-7 branch December 2, 2022 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants