Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump iri-string to 0.5.0 and use shorter type names #225

Closed

Conversation

lo48576
Copy link
Contributor

@lo48576 lo48576 commented Feb 27, 2022

This PR bumps the internal dependency to iri-string crate to the latest stable version.

(Disclaimer: I am the author of iri-string crate.)

Motivation

  • The new version performs a little better.
    • URI resolution is made roughly 3x faster (by quite simple and naive benchmark).
  • The new version has no mandatory dependencies.
    • Dependencies to nom and its indirect deps are removed since v0.5.0.
    • axum still depends on nom, but tokio-http no longer does.
  • Updating the dependency is happy :-).
    • The crate and its items are completely internal, so updating won't cause compatibility issues.

Solution

Just bump the iri-string dependency.

@lo48576
Copy link
Contributor Author

lo48576 commented Feb 28, 2022

Sorry, I overlooked that MSRV of this project is 1.51...

@lo48576 lo48576 closed this Feb 28, 2022
@davidpdrsn
Copy link
Member

@lo48576 what is iri-string's MSRV? As long as we don't go above 1.54 which is axum's MSRV then its probably fine to bump it. We could even bump the MSRV for axum if necessary, as long as its not to the most recent version.

@lo48576
Copy link
Contributor Author

lo48576 commented Feb 28, 2022

iri-string's MSRV is 1.58.0 (released at 2022-01-13).
I can try to lower iri-string's MSRV, but I'm not sure it is worth doing.

@lo48576
Copy link
Contributor Author

lo48576 commented Feb 28, 2022

iri-string 0.5.0 uses String::try_reserve which is stabilized since 1.57.0, so MSRV won't go below that...

@tesaguri
Copy link
Contributor

tesaguri commented Dec 1, 2022

tower-http's MSRV is now 1.60 (#306) so I believe this pull request can be reopened.

@lo48576
Copy link
Contributor Author

lo48576 commented Dec 2, 2022

Thank you for notifying me. I created #312 for bumping iri-string to the newer version.

@lo48576 lo48576 deleted the feature/bump-iri-string-to-0-5 branch December 2, 2022 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants