Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Kubernetes v1.22 #394

Merged
merged 8 commits into from Nov 19, 2021
Merged

Support Kubernetes v1.22 #394

merged 8 commits into from Nov 19, 2021
+334 −167

Conversation

bells17
Copy link
Contributor

@bells17 bells17 commented Nov 1, 2021 •
edited

#386

Update Versions

Name Version Not Update Reference
Kubernetes v1.22.2 https://github.com/kubernetes/kubernetes/blob/v1.22.2/go.mod
controller-runtime v0.10.2 https://github.com/kubernetes-sigs/kubebuilder/blob/v3.2.0/go.mod
controller-tools v0.7.0 https://github.com/kubernetes-sigs/kubebuilder/blob/v3.2.0/go.mod
kind v0.11.1 https://github.com/kubernetes-sigs/kind/tree/v0.11.1
minikube v1.23.2 https://github.com/kubernetes/minikube/tree/v1.23.2
protoc v3.9.1 o
Because topolvm already use a higher version		 https://github.com/container-storage-interface/spec/blob/v1.5.0/lib/go/Makefile#L24
helm v3.7.1 https://github.com/helm/helm/tree/v3.7.1
helm-doc v1.6.0 https://github.com/norwoodj/helm-docs/tree/v1.6.0
ginkgo v1.14.2 o
Because topolvm already use a higher version		 https://github.com/kubernetes-csi/csi-test/blob/v4.3.0/go.mod#L12-L13
gomega v1.10.4 o
Because topolvm already use a higher version		 https://github.com/kubernetes-csi/csi-test/blob/v4.3.0/go.mod#L12-L13
prometheus/client_golang v1.11.0 https://github.com/kubernetes/kubernetes/blob/v1.22.2/go.mod#L73-L75
prometheus/client_model v0.2.0 https://github.com/kubernetes/kubernetes/blob/v1.22.2/go.mod#L73-L75
prometheus/common v0.26.0 https://github.com/kubernetes/kubernetes/blob/v1.22.2/go.mod#L73-L75
grpc v1.42.0 https://github.com/grpc/grpc-go/tree/v1.42.0

@project-bot project-bot bot added this to To do in Development Nov 1, 2021
@bells17 bells17 force-pushed the support-k8s-1.22 branch 5 times, most recently from 593cf59 to fdee1a7 Compare November 1, 2021 11:19
@bells17 bells17 marked this pull request as ready for review November 1, 2021 13:59
llamerada-jp
llamerada-jp reviewed Nov 2, 2021
View reviewed changes
Copy link
Contributor

@llamerada-jp llamerada-jp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the lack of documentation, but the package versions listed in the Makefile and go.mod should be updated if there is no reason to do so.
example:
in Makefile

  • PROTOC_VERSION
  • HELM_VERSION
  • ENVTEST_KUBERNETES_VERSION
  • ...

in go.mod

  • ginko
  • prometheus/*
  • ...

KIND_NODE_VERSION is excluded because it is not used usually.

Could you please update k8s versions in README.md

@toshipp toshipp moved this from To do to Review in progress in Development Nov 2, 2021
@llamerada-jp
Copy link
Contributor

I found the k8s version supported by TopoLVM in charts/topolvm/README.md.
Could you please maintain it and maintenance.md in line with current changes.

@toshipp
Copy link
Contributor

toshipp commented Nov 4, 2021

Grpc 1.42.0 is released and it contains a bug fix that may resolve the issue kubernetes-csi/node-driver-registrar#139. Please update it.

@bells17 bells17 marked this pull request as draft November 4, 2021 02:48
llamerada-jp
llamerada-jp reviewed Nov 5, 2021
View reviewed changes
.github/workflows/helm.yaml Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
charts/topolvm/crds/topolvm.cybozu.com_logicalvolumes.yaml Show resolved Hide resolved
config/crd/bases/topolvm.cybozu.com_logicalvolumes.yaml Show resolved Hide resolved
@bells17
Copy link
Contributor Author

bells17 commented Nov 17, 2021

I suppose ENVTEST_KUBERNETES_VERSION value doesn't need to update because this value is already 1.22.

@bells17
Copy link
Contributor Author

bells17 commented Nov 17, 2021

@llamerada-jp I corrected the points you pointed out.
Would you review this again?

@bells17 bells17 marked this pull request as ready for review November 17, 2021 16:33
llamerada-jp
llamerada-jp approved these changes Nov 18, 2021
View reviewed changes
Copy link
Contributor

@llamerada-jp llamerada-jp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@toshipp toshipp merged commit 1de8538 into main Nov 19, 2021
@toshipp toshipp deleted the support-k8s-1.22 branch November 19, 2021 09:00
Development automation moved this from Review in progress to Done Nov 19, 2021
@bells17 bells17 mentioned this pull request Dec 14, 2021
Merged
@mauriciopoppe
Copy link

hey @toshipp, I read:

Grpc 1.42.0 is released and it contains a bug fix that may resolve the issue kubernetes-csi/node-driver-registrar#139. Please update it.

I was wondering in which release between 1.38.0 and 1.42.0 you saw the bug fix you mentioned

@toshipp
Copy link
Contributor

toshipp commented Jan 19, 2022

@mauriciopoppe
I assume these fixes (grpc/grpc-go#4837 grpc/grpc-go#4633) would resolve the problem. They are introduced in 1.42.0 and 1.41.0 respectively.

@mauriciopoppe
Copy link

thanks, we'll update the dependencies in a future release and see if that helps with kubernetes-csi/node-driver-registrar#139 too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toshipp toshipp toshipp approved these changes

@llamerada-jp llamerada-jp llamerada-jp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Development
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bells17 @llamerada-jp @toshipp @mauriciopoppe