Support Kubernetes v1.22 #85

bells17 · 2021-12-14T12:23:10Z

fix #84
fix #43

Update Versions

Name	Version	Reference
Kubernetes	v1.22.4	https://github.com/kubernetes/kubernetes/blob/v1.22.4/go.mod
controller-runtime	v0.10.3	https://github.com/kubernetes-sigs/kubebuilder/blob/v3.2.0/go.mod
controller-tools	v0.7.0	https://github.com/kubernetes-sigs/kubebuilder/blob/v3.2.0/go.mod
sigs.k8s.io/yaml	v1.2.0	https://github.com/kubernetes-sigs/kubebuilder/blob/v3.2.0/go.mod#L20
helm	v3.7.2	https://github.com/helm/helm/tree/v3.7.2
helm-doc	v1.6.0	https://github.com/norwoodj/helm-docs/tree/v1.6.0
ginkgo	v1.16.4	https://github.com/onsi/gomega/blob/v1.17.0/go.mod#L7
gomega	v1.17.0	https://github.com/onsi/gomega/releases/tag/v1.17.0
prometheus/client_golang	v1.11.0	https://github.com/kubernetes/kubernetes/blob/v1.22.4/go.mod#L73-L75
prometheus/client_model	v0.2.0	https://github.com/kubernetes/kubernetes/blob/v1.22.4/go.mod#L73-L75
prometheus/common	v0.26.0	https://github.com/kubernetes/kubernetes/blob/v1.22.4/go.mod#L73-L75
go-logr/logr	v0.4.0	https://github.com/topolvm/pvc-autoresizer/blob/main/go.mod#L6
spf13/cobra	v1.2.1	https://github.com/spf13/cobra/releases/tag/v1.2.1
prometheus-operator/kube-prometheus	v0.9.0	https://github.com/prometheus-operator/kube-prometheus/tree/v0.9.0

bells17 · 2021-12-14T12:28:30Z

Makefile

-HELM_DOCS_VERSION = 1.5.0
-
-export ENVTEST_K8S_VERSION
+ENVTEST_K8S_VERSION = 1.22.1


Using Kubernetes 1.22.1 with envtest because envtest doesn't provide 1.22.4.

$ ./bin/setup-envtest list (installed) v1.22.1 linux/amd64 (available) v1.22.1 linux/amd64 (available) v1.22.0 linux/amd64 (available) v1.21.4 linux/amd64 (available) v1.21.2 linux/amd64 (available) v1.20.2 linux/amd64 (available) v1.19.2 linux/amd64 (available) v1.19.0 linux/amd64 (available) v1.17.9 linux/amd64 (available) v1.16.4 linux/amd64 (available) v1.15.5 linux/amd64 (available) v1.14.1 linux/amd64 (available) v1.13.1 linux/amd64 (available) v1.12.3 linux/amd64 (available) v1.11.0 linux/amd64 (available) v1.10.1 linux/amd64

bells17 · 2021-12-14T14:43:43Z

e2e/Makefile

-KUBE_PROMETHEUS_VERSION := 0.8.0
-TOPOLVM_VERSION := 3f3854c808df5d68f46ba316e96bfe6bb7edcd48
+KUBE_PROMETHEUS_VERSION := 0.9.0
+TOPOLVM_VERSION := 7c269d04b0b8ac8569c8c76c69569a8f9a0b92a8


7c269d04b0b8ac8569c8c76c69569a8f9a0b92a8 -> https://github.com/topolvm/topolvm/tree/v0.10.3

How about simply specifying v0.13.0 instead of commit hash?

README.md

satoru-takeuchi · 2021-12-22T07:10:15Z

docs/maintenance.md

+pvc-autoresizer depends on some Kubernetes repositories like `k8s.io/client-go` and should support 3 consecutive Kubernets versions at a time.
+Here is the guide for how to upgrade the supported versions.
+Issues and PRs related to the last upgrade task also help you understand how to upgrade the supported versions,
+so checking them together with this guide is recommended when you do this task.


How about adding the link to this PR?

#85

docs/maintenance.md

satoru-takeuchi · 2021-12-22T07:14:03Z

docs/maintenance.md

+-------------------------------------------
+
+pvc-autoresizer depends on some Kubernetes repositories like `k8s.io/client-go` and should support 3 consecutive Kubernets versions at a time.
+Here is the guide for how to upgrade the supported versions.


This line is not necessary because it's clear that this section is for changing the supported Kubernetes versions by the section title.

satoru-takeuchi · 2021-12-22T07:14:12Z

docs/maintenance.md

+Maintenance guide
+=================
+
+This is the maintenance guide for pvc-autoresizer.


This line is not necessary because it's clear that this document is for maintenance by the document title.

docs/maintenance.md

satoru-takeuchi · 2021-12-22T07:45:30Z

docs/maintenance.md

+- `e2e/Makefile`: Makefile for running e2e tests
+
+`git grep 1.18`, `git grep image:`, and `git grep -i VERSION` might help us avoid overlooking necessary changes.
+Please update the versions in the code and docs with great care.


This line is not necesssary.

satoru-takeuchi · 2021-12-22T07:48:05Z

docs/maintenance.md

+### Update dependencies
+
+Next, we should update `go.mod` by the following commands.
+Please note that Kubernetes v1 corresponds with v0 for the release tags. For example, v1.17.2 corresponds with the `v0.17.2` tag.


How about "If the new kubernetes version is v1.x.y", the new pvc-autoresizer's version will be v0.x.y"? In addition, it's better to place this line after the following command lines.

docs/maintenance.md

satoru-takeuchi · 2021-12-22T07:51:42Z

docs/maintenance.md

+
+### Prepare for the next upgrade
+
+We should create an issue for the next upgrade. Besides, Please update this document if we find something to be updated.


Does it mean the next to the next version? In other words, does the new issue for v1.24 if the new supported version is v1.23?

I think so. This text is based on Topolvm maintenance.md.

docs/maintenance.md

daichimukai · 2021-12-22T11:06:55Z

e2e/Makefile

-KUBE_PROMETHEUS_VERSION := 0.8.0
-TOPOLVM_VERSION := 3f3854c808df5d68f46ba316e96bfe6bb7edcd48
+KUBE_PROMETHEUS_VERSION := 0.9.0
+TOPOLVM_VERSION := 7c269d04b0b8ac8569c8c76c69569a8f9a0b92a8


How about simply specifying v0.13.0 instead of commit hash?

daichimukai · 2021-12-22T11:17:43Z

go.mod

@@ -5,14 +5,14 @@ go 1.16
 require (
 	github.com/go-logr/logr v0.4.0
 	github.com/onsi/ginkgo v1.16.4
-	github.com/onsi/gomega v1.13.0
+	github.com/onsi/gomega v1.17.0


How did you choose this version? I checked go.mod of csi-test following maintenance.md, and found csi-test is using ginkgo v1.14.2 and gomega v1.10.4. Or just updating to latest release is enough for this time?

The pvc-autoscaler isn't a CSI driver, so the pvc-autoscaler doesn't need dependent on the csi-test. So I maybe chose the latest release for ginkgo and gomega.

That means this instruction is not true for pvc-autoresizer? Or are there other version indications of ginkgo/gomega elsewhere other than go.mod?

That means this instruction is not true for pvc-autoresizer?

Yes, sorry.
I'll remove this section.

No need to apologize :) Thank you fixing.

Co-authored-by: Satoru Takeuchi <satoru.takeuchi@gmail.com>

Co-authored-by: Daichi Mukai <daichi-mukai@cybozu.co.jp>

Co-authored-by: Satoru Takeuchi <satoru.takeuchi@gmail.com>

bells17 · 2022-01-08T08:44:53Z

@satoru-takeuchi @daichimukai Thank you for your review. It was late, but I updated this PR. Would you review this PR again?

bells17 added 2 commits December 14, 2021 19:51

Add maintenace.md

9d14138

Support Kubernetes v1.22

9a6e0a8

project-bot bot added this to To do in Development Dec 14, 2021

bells17 commented Dec 14, 2021

View reviewed changes

bells17 marked this pull request as ready for review December 14, 2021 14:47

bells17 requested review from toshipp and llamerada-jp December 14, 2021 14:47

bells17 changed the title ~~Support k8s 1.22~~ Support Kubernetes v1.22 Dec 14, 2021

toshipp moved this from To do to Review in progress in Development Dec 15, 2021

toshipp requested review from a team, daichimukai and satoru-takeuchi and removed request for toshipp, llamerada-jp and a team December 15, 2021 05:05

satoru-takeuchi requested changes Dec 22, 2021

View reviewed changes

daichimukai reviewed Dec 22, 2021

View reviewed changes

bells17 and others added 11 commits January 8, 2022 16:58

Update README.md

a96d087

Co-authored-by: Satoru Takeuchi <satoru.takeuchi@gmail.com>

Update docs/maintenance.md

9438e9c

Co-authored-by: Satoru Takeuchi <satoru.takeuchi@gmail.com>

Update docs/maintenance.md

b549e60

Co-authored-by: Satoru Takeuchi <satoru.takeuchi@gmail.com>

Update docs/maintenance.md

4d3826f

Co-authored-by: Satoru Takeuchi <satoru.takeuchi@gmail.com>

Update docs/maintenance.md

b853f98

Co-authored-by: Satoru Takeuchi <satoru.takeuchi@gmail.com>

Update docs/maintenance.md

289d4db

Co-authored-by: Satoru Takeuchi <satoru.takeuchi@gmail.com>

Update docs/maintenance.md

b16e5d0

Co-authored-by: Daichi Mukai <daichi-mukai@cybozu.co.jp>

Update docs/maintenance.md

ee65112

Co-authored-by: Satoru Takeuchi <satoru.takeuchi@gmail.com>

Update docs/maintenance.md

9ed5975

Co-authored-by: Satoru Takeuchi <satoru.takeuchi@gmail.com>

Modify to using git tag

b088450

Update maintenance.md

5208b84

bells17 requested review from daichimukai and satoru-takeuchi January 8, 2022 08:45

Remove a necessary section

1981530

satoru-takeuchi approved these changes Jan 11, 2022

View reviewed changes

daichimukai approved these changes Jan 11, 2022

View reviewed changes

daichimukai merged commit 6fcc42d into main Jan 11, 2022

Development automation moved this from Review in progress to Done Jan 11, 2022

daichimukai deleted the support-k8s-1.22 branch January 11, 2022 05:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support Kubernetes v1.22 #85

Support Kubernetes v1.22 #85

bells17 commented Dec 14, 2021 •

edited by toshipp

bells17 Dec 14, 2021

bells17 Dec 14, 2021

daichimukai Dec 22, 2021

satoru-takeuchi Dec 22, 2021

satoru-takeuchi Dec 22, 2021

satoru-takeuchi Dec 22, 2021

bells17 Jan 8, 2022

satoru-takeuchi Dec 22, 2021

bells17 Jan 8, 2022

satoru-takeuchi Dec 22, 2021

bells17 Jan 8, 2022

satoru-takeuchi Dec 22, 2021

bells17 Jan 8, 2022

daichimukai Dec 22, 2021

daichimukai Dec 22, 2021

bells17 Jan 8, 2022

daichimukai Jan 8, 2022

bells17 Jan 8, 2022

daichimukai Jan 8, 2022

bells17 commented Jan 8, 2022


		### Prepare for the next upgrade

		We should create an issue for the next upgrade. Besides, Please update this document if we find something to be updated.

Support Kubernetes v1.22 #85

Support Kubernetes v1.22 #85

Conversation

bells17 commented Dec 14, 2021 • edited by toshipp

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bells17 commented Jan 8, 2022

bells17 commented Dec 14, 2021 •

edited by toshipp