tracing-attributes: support const values for target and name #2941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpc
requested review from
hawkw,
carllerche,
davidbarsky and
a team
as code owners
dpc
force-pushed
the
24-04-19-pr-2917-fix
branch
from
10df309
to
e6b4819
Compare
dpc
force-pushed
the
24-04-19-pr-2917-fix
branch
2 times, most recently
from
d267cca
to
2ddad6f
Compare
dpc
force-pushed
the
24-04-19-pr-2917-fix
branch
from
2ddad6f
to
1286fdf
Compare
mbrobbel
approved these changes
May 3, 2024
|
I miss this feature so much, every day. :D What's the best way to give it another review, approval, merge, release? :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2460
I only fixed lints making #2917 fail. Seems like they affect
masterbranch as well?