Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tracing-attributes: support const values for target and name #2917

Closed
wants to merge 1 commit into from

Conversation

mbrobbel
Copy link
Contributor

Motivation

Fixes: #2460

Solution

Following the suggestion from #2460 (comment).

@mbrobbel mbrobbel requested review from hawkw, davidbarsky and a team as code owners March 26, 2024 12:37
@dpc
Copy link
Contributor

dpc commented Apr 20, 2024

@mbrobbel Do you know what's the dael with that failing "warnings"?

@mbrobbel
Copy link
Contributor Author

@mbrobbel Do you know what's the dael with that failing "warnings"?

They are unrelated to the changes in this PR.

@mbrobbel
Copy link
Contributor Author

Superseded by #2941

@mbrobbel mbrobbel closed this Apr 22, 2024
@mbrobbel mbrobbel deleted the target-const-values branch April 22, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Const value as target = value in instrument.
2 participants