Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

opentelemetry: fix exception fields defaults in docs #2200

Merged
merged 2 commits into from
Jul 1, 2022
Merged

opentelemetry: fix exception fields defaults in docs #2200

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ca830d2
opentelemetry: fix exception fields defaults in docs
hawkw Jul 1, 2022
3531c93
Merge branch 'v0.1.x' into eliza/fix-exn-docs
hawkw Jul 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions tracing-opentelemetry/src/layer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -483,7 +483,7 @@ where
/// These attributes follow the [OpenTelemetry semantic conventions for
/// exceptions][conv].
///
/// By default, these fields are enabled
/// By default, these attributes are not recorded.
///
/// [conv]: https://opentelemetry.io/docs/reference/specification/trace/semantic_conventions/exceptions/
pub fn with_exception_fields(self, exception_fields: bool) -> Self {
Expand All @@ -506,7 +506,7 @@ where
/// These attributes follow the [OpenTelemetry semantic conventions for
/// exceptions][conv].
///
/// By default, this is enabled
/// By default, these attributes are not propagated to the span.
///
/// [conv]: https://opentelemetry.io/docs/reference/specification/trace/semantic_conventions/exceptions/
pub fn with_exception_field_propagation(self, exception_field_propagation: bool) -> Self {
Expand Down