Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opentelemetry: fix exception fields defaults in docs #2200

Merged
merged 2 commits into from Jul 1, 2022

Conversation

hawkw
Copy link
Member

@hawkw hawkw commented Jul 1, 2022

Motivation

Currently, the tracing-opentelemetry docs indicate that the support
for OpenTelemetry's exception semantic conventions added in #2135 is
enabled by default. However, this is not the case --- this feature was
changed to opt-in rather than opt-out prior to merging PR #2135.

Solution

This branch updates the docs to state that these features are disabled
by default, rather than enabled by default.

Currently, the `tracing-opentelemetry` docs indicate that the support
for OpenTelemetry's exception semantic conventions added in #2135 is
enabled by default. However, this is not the case --- this feature was
changed to opt-in rather than opt-out prior to merging PR #2135.

This branch updates the docs to state that these features are disabled
by default, rather than enabled by default.
@hawkw hawkw requested review from jtescher and a team as code owners July 1, 2022 17:00
@hawkw hawkw enabled auto-merge (squash) July 1, 2022 17:06
@hawkw hawkw merged commit 2659ccf into v0.1.x Jul 1, 2022
@hawkw hawkw deleted the eliza/fix-exn-docs branch July 1, 2022 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants