process: add ProcessDriver to handle orphan reaping #2907
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
wait
call in the destructor, nor do we have something like async-destructors to perform the clean up for uskill_on_drop
flag will terminate the child process on drop, there is no guarantee that the caller will callchild.await
which will leave a zombie process floating around and can lead to exhaustion of the pid spaceSolution
ProcessDriver
(only on Unix platforms) which will reap the orphaned processes spawned by tokio, gradually eliminating them as they finally exit.Refs #2685
Refs #2841