Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: refactor runtime driver useage of Either #2916

Closed
ipetkov opened this issue Oct 6, 2020 · 0 comments · Fixed by #2918
Closed

chore: refactor runtime driver useage of Either #2916

ipetkov opened this issue Oct 6, 2020 · 0 comments · Fixed by #2918
Assignees
@ipetkov
Labels
A-tokio Area: The main tokio crate C-maintenance Category: PRs that clean code up or issues documenting cleanup. M-runtime Module: tokio/runtime

Comments

@ipetkov
Copy link
Member

ipetkov commented Oct 6, 2020

Follow up of comment on #2907 instead of having an Either<XDriver, Fallback> for the I/O, signal, and process drivers, we can likely roll them up in a single Either<IOStack, Fallback> based on whether I/O is enabled.
@ipetkov ipetkov added C-maintenance Category: PRs that clean code up or issues documenting cleanup. A-tokio Area: The main tokio crate M-runtime Module: tokio/runtime labels Oct 6, 2020
@ipetkov ipetkov self-assigned this Oct 6, 2020
@ipetkov ipetkov mentioned this issue Oct 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ipetkov ipetkov

Labels
A-tokio Area: The main tokio crate C-maintenance Category: PRs that clean code up or issues documenting cleanup. M-runtime Module: tokio/runtime
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: refactor runtime driver useage of Either and cfgs tokio-rs/tokio
1 participant
@ipetkov