fs: implement AsRaw{Fd,Handle} for tokio::fs::File (#1364) #1640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xinkai
force-pushed
the
file_as_raw_fd_handle
branch
from
147efdd
to
c6a180b
Compare
carllerche
reviewed
Nov 1, 2019
|
|
||
| impl AsRawFd for File { | ||
| fn as_raw_fd(&self) -> RawFd { | ||
| let std = self.std.clone(); |
There was a problem hiding this comment.
You're right. It doesn't need a clone() here. I must be thinking about something else.
Moved file.rs to file/mod.rs to get around mod visibility issue.
Xinkai
force-pushed
the
file_as_raw_fd_handle
branch
from
c6a180b
to
cac934f
Compare
|
It's also my bad to lose track of this issue, as I have been busy moving from one city to another. I will continue working on this (implement tests) when I am done with the rest of the moving routine. |
Xinkai
added a commit
to Xinkai/tokio
that referenced
this pull request
Dec 3, 2019
carllerche
pushed a commit
that referenced
this pull request
Dec 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Exposing tokio::fs RawFd/RawHandle
Solution
Moved file.rs to file/mod.rs to get around mod visibility issue.