Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! This is my first open source rust PR to a major project, so please let me know if anything looks wrong, or if there's a better practice to implement this!
There are cases where a user may want to grab the underlying fd of a
tokio::fs::File, example: if a user wanted to use a non-blocking splice
copy to the file, they would need to be able to pull out the RawFd.
Since std::fs::File implements this, it seems like a safe thing to
expose from tokio::fs::File.
Motivation
I was implementing a non-blocking splice copy, but found that
tokio::fs::File
does not implementAsRawFd
which was surprising sincestd::fs::File
implements this. I thought it would be nice to add here as well.Solution
The solution is pretty easy since the underlying std File type already implements this.