Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Only report focused test keyword, not the whole test #231

Merged
merged 1 commit into from
Apr 13, 2020
Merged

fix: Only report focused test keyword, not the whole test #231

merged 1 commit into from
Apr 13, 2020

Conversation

DamienCassou
Copy link
Contributor

Description

Fixes issue #230.

How has this been tested?

I added a new test and ran all of them.

Types of changes

  • Test change (non-breaking change which adds additional test scenarios)
  • Refactor change (non-breaking change updates coding styles)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have ran yarn run test and everything passes
  • My code follows the code style of this project
  • I have updated the documentation where necessary
  • I have read the CONTRIBUTING document
  • I have added tests to cover my changes
  • All new and existing tests pass

@DamienCassou
fix(no-focused-test): Only report focused test keyword, not test
7fd1095 
Change endLine and endColumn so only the focused test keyword is
reported as problematic instead of the whole test call. The previous
behavior made working on a focused much harder with editors selecting
all code from line to endLine.

Fixes issue tlvince#230.
@DamienCassou DamienCassou mentioned this pull request Apr 12, 2020
Closed
tlvince
tlvince approved these changes Apr 13, 2020
View reviewed changes
Copy link
Owner

@tlvince tlvince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@tlvince tlvince merged commit 796dddf into tlvince:master Apr 13, 2020
@tlvince
Copy link
Owner

tlvince commented Apr 13, 2020

🎉 This PR is included in version 4.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tlvince tlvince tlvince approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@DamienCassou @tlvince