New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jasmine/no-focused-tests' endLine includes too much of the test #230
Labels
Comments
6 tasks
DamienCassou
added a commit
to DamienCassou/eslint-plugin-jasmine
that referenced
this issue
Apr 12, 2020
DamienCassou
added a commit
to DamienCassou/eslint-plugin-jasmine
that referenced
this issue
Apr 12, 2020
Change endLine and endColumn so only the focused test keyword is reported as problematic instead of the whole test call. The previous behavior made working on a focused much harder with editors selecting all code from line to endLine. Fixes issue tlvince#230.
11 tasks
Please see #231 for a fix. |
tlvince
pushed a commit
that referenced
this issue
Apr 13, 2020
Change endLine and endColumn so only the focused test keyword is reported as problematic instead of the whole test call. The previous behavior made working on a focused much harder with editors selecting all code from line to endLine. Fixes issue #230.
Closed by 796dddf |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
jasmine/no-focused-tests
returns anendLine
value that represents the whole test. This makes it particularly inconvenient to code on afit
test. As you can see, everything is underlined:To Reproduce
Write this code:
Enable
jasmine/no-focused-tests
Run
npx eslint --format=json .
The
endLine
is 9.Expected behaviour
That
endLine
is the same as theline
, i.e., 2.The rule mocha/no-exclusive-tests does what I expect by only returning the
only
part as being wrong:Context
The text was updated successfully, but these errors were encountered: