[BUG] Will output all changed files if not file matches the **/*.sql pattern

[ecmadao]

Is there an existing issue for this?

• I have searched the existing issues

Does this issue exist in the latest version?

• I'm using the latest release

Describe the bug?

If the files pattern contains **/*.sql, and it didn't match any changed files in the pull request, will print a warning:

No match found for specified patterns. Ensure that subdirectory patterns are prefixed with "**/" and all multi line string patterns are specified without quotes. See: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#filter-pattern-cheat-sheet

And the action will output all changed files, seems this doesn't make sense.

To Reproduce

1. Create a workflow like:

on: [pull_request]

jobs:
  test-workflow:
    runs-on: ubuntu-latest
    name: Changed files
    steps:
      - uses: actions/checkout@v3
      - name: Get changed files
        id: changed-files
        uses: tj-actions/changed-files@v24.1
        with:
          files: |
            **/*.sql 
      - name: Echo files
        run: echo ${{ steps.changed-files.outputs.all_changed_files }}
        shell: bash

Note: the files must has the pattern: **/*.sql

2. Make some changes (not change any SQL files)
3. Create the pull request and check the action.

What OS are you seeing the problem on?

ubuntu-latest or ubuntu-20.04

Expected behavior?

The action should return empty as no changed files can match the **/*.sql pattern.

Relevant log output

No response

Anything else?

N/A

Code of Conduct

• I agree to follow this project's Code of Conduct

[github-actions]

Thanks for reporting this issue, don't forget to star this project to help us reach a wider audience.

[jackton1]

The solution here would be to validate the patterns.

[ecmadao]

The interesting thing is if the pattern is something like **/*.md, and even though the PR doesn't have any markdown file changes, it works well with empty output. I only found this issue if the pattern is **/*.sql

[jackton1]

That's strange, I'll expect the warning to show up for non valid glob patterns