Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: several optimize #4

Merged
merged 2 commits into from Aug 9, 2022
Merged

chore: several optimize #4

merged 2 commits into from Aug 9, 2022

Conversation

ecmadao
Copy link
Collaborator

@ecmadao ecmadao commented Aug 9, 2022

Use umani/changed-files instead of tj-actions/changed-files to get changed files

The action tj-actions/changed-files has a bug, it will output all changed files if no file matches the **/*.sql pattern. I have reported the issue but haven't been fixed yet. (the author's fix only removes the warning log, not actually fixed this issue.)

Add file-pattern parameter

Optional. Users can set the target SQL files. For example, if they only want to subscribe to the SQL file changes in the db folder, they can set this parameter to ^db/.*\.sql$.

Update the README

Link our PRs as example.

Copy link
Contributor

@tianzhou tianzhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@d-bytebase d-bytebase merged commit 98abd38 into main Aug 9, 2022
@ecmadao ecmadao deleted the chore/optimize branch August 9, 2022 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants