Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: only lint READMEs when changed #11677

Merged
merged 1 commit into from Aug 17, 2022

Conversation

powersj
Copy link
Contributor

@powersj powersj commented Aug 15, 2022

Update changed-files library to grab a fix to the glob library that was outputting all changed files if no file matched the pattern. Additionally, update the glob to be clear about where to start and put a check to only run the markdown linter with the changed files matching the previous filter.

Test Examples:

@powersj powersj changed the title fake commit chore: only lint READMEs when changed Aug 15, 2022
@powersj powersj marked this pull request as ready for review August 15, 2022 20:19
@powersj powersj requested a review from reimda August 15, 2022 20:20
Update changed-files library to grab a fix to the glob library that was
outputing all changed files if no file matched the pattern. Update glob,
add conditional.
Copy link
Contributor

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for tackling this @powersj!

@srebhan srebhan self-assigned this Aug 15, 2022
@srebhan srebhan added ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. chore labels Aug 15, 2022
@powersj powersj merged commit 0568006 into influxdata:master Aug 17, 2022
@powersj powersj deleted the fix/readme-linter-changed branch August 17, 2022 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants