Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return empty WorkflowContextList from GetWorkflowContextList #575

Closed
wants to merge 1 commit into from
Closed

Return empty WorkflowContextList from GetWorkflowContextList #575

wants to merge 1 commit into from

Conversation

swills
Copy link
Contributor

@swills swills commented Dec 30, 2021

Fixes #391

@swills swills force-pushed the issue391 branch 2 times, most recently from f340bb9 to 6b9e1ba Compare December 30, 2021 09:25
displague
displague reviewed Jan 3, 2022
View reviewed changes
grpc-server/tinkerbell.go Outdated Show resolved Hide resolved
@displague
Copy link
Member

displague commented Jan 3, 2022 •
edited

@swills See the DCO notes https://github.com/tinkerbell/tink/pull/575/checks?check_run_id=4695236298 and please squash the second commit into the first.

I tried to reproduce the make generate problem locally but I ran into problems with make tools not being providing the tools needed for make generate. For CI, this may be corrected by 73ca7c7

@swills
Return empty WorkflowContextList from GetWorkflowContextList
5a233ef 
Fixes tinkerbell#391

Signed-off-by: Steve Wills <steve@mouf.net>
@swills
Copy link
Contributor Author

swills commented Jan 3, 2022

@swills See the DCO notes https://github.com/tinkerbell/tink/pull/575/checks?check_run_id=4695236298 and please squash the second commit into the first.

Done

I tried to reproduce the make generate problem locally but I ran into problems with make tools not being providing the tools needed for make generate. For CI, this may be corrected by 73ca7c7

Maybe. The real fix imho is actions/setup-go#175 see also #553

@jacobweinstock
Copy link
Member

Hey @swills, sorry for having this sit so long. Would you mind checking out the merge/rebase conflicts?

@chrisdoherty4
Copy link
Member

@swills we'd love to get this in. Are you able to rebase and address any issues?

@chrisdoherty4 chrisdoherty4 self-assigned this Oct 6, 2022
@chrisdoherty4
Copy link
Member

Thanks for the effort. Unfortunately this change is redundant because of #654.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@displague displague displague left review comments

Assignees

@chrisdoherty4 chrisdoherty4

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Listing workflows by hardware without any workflows returns GRPC error
4 participants
@swills @displague @jacobweinstock @chrisdoherty4