Return empty WorkflowContextList from GetWorkflowContextList

Fixes #391
tinkerbell · Dec 30, 2021 · f340bb9 · f340bb9
1 parent b18b238
commit f340bb9
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/grpc-server/tinkerbell.go b/grpc-server/tinkerbell.go
@@ -68,7 +68,8 @@ func (s *server) GetWorkflowContextList(ctx context.Context, req *pb.WorkflowCon
 			WorkflowContexts: wfContexts,
 		}, nil
 	}
-	return nil, nil
+
+	return &pb.WorkflowContextList{WorkflowContexts: []*pb.WorkflowContext{}}, nil
 }
 
 // GetWorkflowActions implements tinkerbell.GetWorkflowActions.

diff --git a/grpc-server/tinkerbell_test.go b/grpc-server/tinkerbell_test.go
@@ -135,13 +135,11 @@ func TestGetWorkflowContextList(t *testing.T) {
 				assert.True(t, tc.want.expectedError)
 				return
 			}
-			if err == nil && res == nil {
-				assert.False(t, tc.want.expectedError)
-				return
-			}
 			assert.NoError(t, err)
 			assert.NotNil(t, res)
-			assert.Len(t, res.WorkflowContexts, 1)
+			assert.False(t, tc.want.expectedError)
+			assert.IsType(t, &pb.WorkflowContextList{}, res)
+			assert.IsType(t, []*pb.WorkflowContext{}, res.WorkflowContexts)
 		})
 	}
 }